Skip to content

chore(pubsub): release 1.1.0#9950

Merged
plamut merged 2 commits intogoogleapis:masterfrom
pradn:release-pubsub-1.0.3
Dec 10, 2019
Merged

chore(pubsub): release 1.1.0#9950
plamut merged 2 commits intogoogleapis:masterfrom
pradn:release-pubsub-1.0.3

Conversation

@pradn
Copy link
Copy Markdown
Contributor

@pradn pradn commented Dec 10, 2019

Release a new version since there have been a few fixes.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2019
@pradn pradn changed the title pubsub(chore): release 1.0.3 chore(pubsub): release 1.0.3 Dec 10, 2019
Copy link
Copy Markdown
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few comments about the grammar and the semantic version bump, although not super opinionated (feel free to disagree :) )

Edit: Oh, and the commit message should also be amended to follow the guideline (the check currently fails).

…ause the stop method was added to the publisher client.
@pradn pradn changed the title chore(pubsub): release 1.0.3 chore(pubsub): release 1.1.0 Dec 10, 2019
Copy link
Copy Markdown
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plamut plamut merged commit 4d90932 into googleapis:master Dec 10, 2019
@pradn
Copy link
Copy Markdown
Contributor Author

pradn commented Dec 10, 2019

@plamut
Copy link
Copy Markdown
Contributor

plamut commented Dec 10, 2019

@pradn I manually changed the tag and release title to 1.1.0, please check if a manual run is needed to publish the release to PyPI (the bot might be tempted to upload the 1.0.3 tag).

Both tags point to the same commit, though.

@pradn
Copy link
Copy Markdown
Contributor Author

pradn commented Dec 10, 2019

Okay, I should have just made a new branch/PR with 1.0.1 to make it simple.

I deleted the 1.0.3 tag in the this repo. The 1.1.0 tag looks good. I added the "autorelease:tagged" flag back on to continue the release to PyPi.

Hopefully everything works now.

@plamut
Copy link
Copy Markdown
Contributor

plamut commented Dec 11, 2019

It appears the bot will have to be run manually, the similar thing happened when releasing API Core recently.

(cc: @busunkim96 )

@busunkim96
Copy link
Copy Markdown
Contributor

Released to pypi: https://pypi.org/project/google-cloud-pubsub/1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. autorelease: published cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants