Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

test(samples): add backoff to cluster creation sample #362

Merged
tseaver merged 2 commits into from
Jul 13, 2021
Merged

test(samples): add backoff to cluster creation sample #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0267cd
doc(samples): wrap backoff around cluster creation sample
tseaver Jul 12, 2021
dc49279
chore: lint
tseaver Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions samples/instanceadmin/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
google-cloud-bigtable==2.0.0
backoff==1.11.0
8 changes: 6 additions & 2 deletions samples/instanceadmin/test_instanceadmin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@
import time
import warnings

import backoff
from google.api_core import exceptions
from google.cloud import bigtable

import pytest

import instanceadmin
Expand Down Expand Up @@ -128,7 +129,10 @@ def test_add_and_delete_cluster(capsys, dispose_of):
capsys.readouterr() # throw away output

# Add a cluster to that instance
instanceadmin.add_cluster(PROJECT, INSTANCE, CLUSTER2)
# Avoid failing for "instance is currently being changed" by
# applying an exponential backoff
w_backoff = backoff.on_exception(backoff.expo, exceptions.ServiceUnavailable)
w_backoff(instanceadmin.add_cluster)(PROJECT, INSTANCE, CLUSTER2)
out = capsys.readouterr().out
assert f"Adding cluster to instance {INSTANCE}" in out
assert "Listing clusters..." in out
Expand Down