Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

fix: directly append to pb for better read row performance #382

Merged
crwilcox merged 1 commit into from
Jul 20, 2021
Merged

fix: directly append to pb for better read row performance #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/bigtable/row_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def _update_message_request(self, message):
:param message: The ``ReadRowsRequest`` protobuf
"""
for each in self.row_keys:
message.rows.row_keys.append(_to_bytes(each))
message.rows.row_keys._pb.append(_to_bytes(each))
Copy link
Copy Markdown
Contributor

@kolea2 kolea2 Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it at all possible we could run into the same issues we same here with lazy eval? #359

Copy link
Copy Markdown
Contributor Author

@crwilcox crwilcox Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't expect so. We have applied a similar patch to firestore and pubsub libraries. row_keys.append calls proto plus which ultimately will interact with _pb. The way it does this though is not fast. :(


for each in self.row_ranges:
r_kwrags = each.get_range_kwargs()
Expand Down