Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

docs: clarify the types of Message parameters#486

Merged
tseaver merged 2 commits intogoogleapis:mainfrom
plamut:iss-485
Sep 2, 2021
Merged

docs: clarify the types of Message parameters#486
tseaver merged 2 commits intogoogleapis:mainfrom
plamut:iss-485

Conversation

@plamut
Copy link
Copy Markdown
Contributor

@plamut plamut commented Sep 2, 2021

Closes #485.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested review from a team and anguillanneuf September 2, 2021 10:59
@plamut plamut requested a review from a team as a code owner September 2, 2021 10:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 2, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 2, 2021
@plamut
Copy link
Copy Markdown
Contributor Author

plamut commented Sep 2, 2021

@jceresini If you have time, please have a look at this and let me know if the changed docs are now more clear to you, the library user. Thanks!

@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2021
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 2, 2021
@jceresini
Copy link
Copy Markdown

This definitely helps, and makes sense. Thanks.

@tseaver tseaver merged commit 633e91b into googleapis:main Sep 2, 2021
@plamut plamut deleted the iss-485 branch September 2, 2021 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when manually instantiaing message.Message in unit tests

4 participants