adding absolute timestamp to ASC reader

[cperkulator]

needed timestamps to be absolute so I added this.

Probably needs some error handling. Will get to it when I have the chance.

[felixdivo]

This might need a rebase due to #741 having been merged two days ago.

[sou1hacker]

Was wondering if we can make this optional by a flag passed to LogReader? In most of our use cases, we would actually prefer the current timestamp format which is easier to read and co-relate back with the ascii logs file. Maybe even make the existing implementation the default approach?

[felixdivo]

@cperkulator Do you plan on having another look at this?

[cperkulator]

@cperkulator Do you plan on having another look at this?

oops I really apologize. I'll get this rebased and try and wrap it up today

[codecov]

Codecov Report

Merging #761 (7389b23) into develop (4048765) will decrease coverage by 4.24%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #761      +/-   ##
===========================================
- Coverage    70.75%   66.51%   -4.25%     
===========================================
  Files           78       78              
  Lines         7551     7561      +10     
===========================================
- Hits          5343     5029     -314     
- Misses        2208     2532     +324     

[felixdivo]

Would you mind adding one test for each of the modes relative and absolute? That would make your PR really great!

[felixdivo]

@Mergifyio update

[mergify]

Command update: success

Branch already up to date

[cperkulator]

Not sure what is up with codecov but according to tox, everything I added is covered.

[felixdivo]

Not sure what is up with codecov but according to tox, everything I added is covered.

Yeah, just ignore it in this case. It's somewhat broken.

[felixdivo]

@cperkulator Somehow, there seem to be sudden errors on the develop branch. See here. Do you know what's happening? They are probably related to this PR, right?

[cperkulator]

@cperkulator Somehow, there seem to be sudden errors on the develop branch. See here. Do you know what's happening? They are probably related to this PR, right?

They all passed before the merge right? I'll take a look.

[cperkulator]

@cperkulator Somehow, there seem to be sudden errors on the develop branch. See here. Do you know what's happening? They are probably related to this PR, right?

They all passed before the merge right? I'll take a look.

@felixdivo alright figured it out. Those failing tests create a header in the temporary ASC file:

Since this time is before 1970 (and thus not representable by POSIX time) then we get an OSError exception.

I'll submit a new PR to catch that error

[felixdivo]

Okay, sounds plausible. Thanks for figuring it out!