Add reactions to Issue type#483
Add reactions to Issue type#483kafji wants to merge 2 commits intohaskell-github:masterfrom kafji:master
Conversation
| , issueId :: !(Id Issue) | ||
| , issueComments :: !Int | ||
| , issueMilestone :: !(Maybe Milestone) | ||
| , issueReactions :: !(Maybe IssueReactions) |
There was a problem hiding this comment.
I suppose this is https://docs.github.com/en/rest/reactions#list-reactions-for-an-issue , is it?
Would you mind adding the link as a haddock comment to this field?
There was a problem hiding this comment.
Hi Andreas, thanks for reviewing this.
I suppose this is https://docs.github.com/en/rest/reactions#list-reactions-for-an-issue , is it?
It isn't. It's for key reactions in list-repository-issues.
If you have curl & jq, this should print a json object that matches IssueReactions which differ from list-reactions-for-an-issue.
curl \
-X GET \
-H "Accept: application/vnd.github.v3+json" \
https://api.github.com/repos/ghc-proposals/ghc-proposals/issues \
| jq .[0].reactionsThe .[0].reactions.url however, is indeed a link for list-reactions-for-an-issue. Do you think we should add link to list-reactions-for-an-issue for IssueReactions.issueReactionsUrl?
|
Thanks for the PR, @kafji! |
|
Please add a link to the documentation as given in your comment #483 (comment), and add a demonstration of this new feature to |
for deserializing issue's reactions which returned in some of the endpoints, for example https://api.github.com/repos/ghc-proposals/ghc-proposals/issues
I also add
/.hspec-failuresto gitignore.