fix: install pip in venv for runtime package installation#12668
Closed
VedantMadane wants to merge 2 commits intoinfiniflow:mainfrom
Closed
fix: install pip in venv for runtime package installation#12668VedantMadane wants to merge 2 commits intoinfiniflow:mainfrom
VedantMadane wants to merge 2 commits intoinfiniflow:mainfrom
Conversation
The uv sync command creates a minimal virtual environment without pip. However, the ensure_docling function in entrypoint.sh uses 'uv pip install' at runtime, which requires pip to be present in the target environment. This change ensures pip is installed in the venv during the build stage, allowing runtime package installation to work correctly when USE_DOCLING=true. Fixes infiniflow#12651
dosubot
bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the Docker build failure when running with USE_DOCLING=true .
Problem
After migrating to uv sync, the virtual environment no longer contains pip. However, the ensure_docling function in entrypoint.sh uses uv pip install at runtime to install the docling package when needed.
The error manifests as:
/ragflow/.venv/bin/python3: No module named pip
Solution
Add uv pip install pip after uv sync in the builder stage to ensure pip is available in the virtual environment for runtime package installation.
Changes to Dockerfile:
Added uv pip install pip after uv sync --python 3.12 --frozen
Fixes #12651