Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
The swipe-to-go-back gesture on ion-router-outlet is controlled differently across frameworks:
swipeBackEnabledconfig option on every swipe attempt in their framework wrappers (StackManager.canStart()andIonRouterOutlet.canStart())swipeGesturesetterswipeBackEnabledconfig optionWhat is the new behavior?
ion-router-outletnow exposes a publicswipeGestureproperty in core that controls the swipe-to-go-back gesture per outlet instance. It defaults to true in "ios" mode and false in "md" mode, matching existing behavior.swipeBackEnabledconfig is read once when the outlet mounts (as the default forswipeGesture) rather than checked on every swipe attemptswipeGestureproperty for consistency<IonRouterOutlet swipeGesture={false} />swipeBackEnabledonce at startup require no changesDoes this introduce a breaking change?
Other information
I tried to align the updates to the BREAKING.md documents with the RR6 PR's changes to it to prevent issues from merging as much as possible