Dynamic imports#419
Merged
nazarepiedady merged 4 commits intojavascript-tutorial:masterfrom Apr 8, 2024
Merged
Conversation
nazarepiedady
requested review from
WintKhetSan,
joannaaldebaran,
jonnathan-ls,
lizzie136,
luizclr,
meilune,
odsantos and
vplentinax
and removed request for
WintKhetSan,
joannaaldebaran,
lizzie136,
meilune and
vplentinax
Renan-Olovics
suggested changes
Feb 21, 2024
|
Please make the requested changes. After it, add a comment "/done". |
danilolmc
force-pushed
the
update-dynamic-imports
branch
from
342d4cd to
192eff9
Compare
Contributor
Author
|
/done |
Member
|
@peruibeloko, @jonnathan-ls, could you review this pull request? |
jonnathan-ls
approved these changes
Apr 7, 2024
Contributor
jonnathan-ls
left a comment
jonnathan-ls
left a comment
There was a problem hiding this comment.
LGTM
I added a commit with some adjustments such as pending translations 780f934
Contributor
I added my review with contribution @nazarepiedady |
nazarepiedady
approved these changes
Apr 8, 2024
Member
nazarepiedady
left a comment
nazarepiedady
left a comment
There was a problem hiding this comment.
It is good, so I will pass it forward.
|
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.