Add includeNoArgsConstructor option#1622
Open
lengors wants to merge 2 commits intojoelittlejohn:masterfrom
Open
Add includeNoArgsConstructor option#1622lengors wants to merge 2 commits intojoelittlejohn:masterfrom
includeNoArgsConstructor option#1622lengors wants to merge 2 commits intojoelittlejohn:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The no-args constructor is not necessary for all serializarers and deserializers. For example. when using Micronaut with serde, it's perfectibily acceptable to not have the no-args constructor for serialization and deserialization to be successful. Not only that, but it actually interferes with the deserialization process when the
includeSettersoption is set to false (all properties constructor would require being annotated with@JsonCreatorfor all properties to be set accordingly).Example showcasing motivation: micronaut-serde-examples.
Purposal
As such, I'm creating this PR which implements the
includeNoArgsConstructoroption, set to true by default for backwards compatibility reasons and allows the user to disable the generation of the no-args constructor.Edit: second commit reverts default compiler version for integration-tests to
1.6because I had change it to1.8to run the tests locally and accidentally committed it