De-duplicate identical classes and avoid __1

[matusfaro]

Hello,

Thank you very much for your amazing project!

I know you have previously decided (in #1082) not to support de-duplication of identical classes and instead suggest to use $refs, but please re-consider.

This seems to be an arguably common request: #1562 #1559 #1151 #1192 #1081 #784 #114 #112 #885

Mainly this will solve the case where it's not possible to modify the input and replace $refs (my case), but it'll also make it friendlier for others not having to refactor their input to use $refs.

Take a look at the implementation which is fairly simple. I'd appreciate any feedback on the implementation, even if you don't decide to go ahead with it.

If I still can't change your mind, no problem, I will maintain this change in my fork.

---

UPDATE: For now I have it in my repo published under my groupId if anyone wants to use it, e.g.:

<plugin>
    <groupId>io.dataspray</groupId>
    <artifactId>jsonschema2pojo-maven-plugin</artifactId>
    <version>1.2.8</version>
</plugin>

Make sure to use the new property --useDeduplication

[matusfaro]

Track duplicates in each RuleFactory instance

[matusfaro]

Wrap specific Rules that require de-duplication.

[matusfaro]

Each Rule has its own individual cache

[matusfaro]

Performs de-duplication here during rule transformation of Schema to result.

[matusfaro]

Using SHA-256 of the compact JSON string for de-duplication.

[ahasgx]

<plugin>
    <groupId>io.dataspray</groupId>
    <artifactId>jsonschema2pojo-maven-plugin</artifactId>
    <version>1.2.8</version>
</plugin>

Hi, I use this plugin, but it still generates the Menu class with __1

MenuItem.json:
{ "type" : "object", "javaType" : "net.chrisrichardson.ftgo.restaurantservice.events.MenuItem", "properties" : { "id" : { "type" : "string" }, "name" : { "type" : "string" }, "price" : { "type" : "string" } }, "required": [ "id", "name", "price" ] }

Menu.json:
{ "type" : "object", "javaType" : "net.chrisrichardson.ftgo.restaurantservice.events.Menu", "properties" : { "menuItems": { "type": "array", "items": { "$ref": "MenuItem.json" } } } }
RestaurantCreated.json:
{ "type": "object", "properties": { "menu": { "type": "object", "items": { "$ref": "Menu.json" } } }, "required": [ "menu" ], "javaInterfaces": [ "io.eventuate.tram.events.common.DomainEvent" ] },

RestaurantMenuRevised.json:
{ "type": "object", "properties": { "name": { "type": "string" }, "menu": { "type": "object", "items": { "$ref": "Menu.json" } } }, "required": ["menu"], "javaInterfaces": [ "io.eventuate.tram.events.common.DomainEvent" ] }

[matusfaro]

Interesting, it deduplicated MenuItem, but not Menu by reference, it's possible I missed deduplicating references. I'll take a look later when I have time.

In the meantime could you try giving a "title":"Menu" in Menu.json?

[matusfaro]

@ahasgx I added additional tests across various json schemas and it is all working fine. Couple of notes:

1. Did you set the new property useDeduplication to true?
2. Your example above has invalid json schema, particularly in RestaurantCreated.name and RestaurantMenuRevised.menu both have a field items which is only valid for arrays, not objects. Although this shouldn't be related to the issue we are discussing as I tested this as well.

[ahasgx]

Sorry, I missed the important property useDeduplication.
it works now, thanks a lot.

[ielrhaouti-cc]

works like a charm! any news on this PR ? will it be merged soon ? thanks

[matusfaro]

The owner @joelittlejohn is likely taking a well deserved break. (hasn't been active in this repo for last 7 months)

For now you can use my fork and if this gets merged you can switch back to it later.