Add code quality tools with dedicated GitHub Actions#1768
Open
joelittlejohn wants to merge 5 commits intomasterfrom
Open
Add code quality tools with dedicated GitHub Actions#1768joelittlejohn wants to merge 5 commits intomasterfrom
joelittlejohn wants to merge 5 commits intomasterfrom
Conversation
Owner
Author
|
I feel bad for the amount of GitHub's compute I'm using :) but are these useful? Some more work needed to create useful reports I think, but I like how the dedicated GitHub actions mean that the checks on GitHub show exactly which tool is complaining. |
joelittlejohn
force-pushed
the
add-code-quality-tools
branch
2 times, most recently
from
51494a0 to
8065144
Compare
joelittlejohn
force-pushed
the
add-code-quality-tools
branch
8 times, most recently
from
89c545b to
13ac5f2
Compare
Add four code quality tools, each in its own Maven profile and GitHub Action: - SpotBugs (-Pspotbugs): Static bug detection - PMD (-Ppmd): Code style and best practices - Error Prone (-Perrorprone): Compile-time error checking - JaCoCo (-Pjacoco): Code coverage reporting with aggregate report These tools only run in their dedicated workflows, not during normal CI builds. The gradle-plugin module overrides the errorprone profile to continue using the groovy-eclipse-compiler instead of Error Prone. Also fixes: - FormatRule: Make static date format fields final (SpotBugs high priority) - JsonPointerUtils: Replace double-brace initialization (Error Prone)
joelittlejohn
force-pushed
the
add-code-quality-tools
branch
from
13ac5f2 to
a2dc49a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add four code quality tools, each in its own Maven profile and GitHub Action:
These tools only run in their dedicated workflows, not during normal CI builds.
Also fixes:
This is just an experiment for now. I'm interested to see what it's like to have these separate actions run and examine the code.