Draft
Conversation
- Add support for allOf, which merges all rules together - Add support for anyOf/oneOf, which implement subtypes and a 'marker' interface that all subtypes will implement - Add support for a new 'discriminator' schema property that can be used to specify a property that will hold the type name
joelittlejohn
force-pushed
the
allof-anyof-oneof
branch
from
19c59dd to
2028ccd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a vision for allOf/anyOf/oneOf that I've been thinking about for many years. The approach is simple but will hopefully support a very large percentage of use-cases for these keywords.
To achieve polymorphic deserialisation, there's a new 'discriminator' keyword, similar to OpenAPI's discriminator keyword, to specify the JSON property that will indicate the type name.
This PR is not complete, but it shows where I think we'll go.