Only show use-pro deprecation message on top action input#67
Merged
dominikschubert merged 1 commit intomainfrom Apr 2, 2026
Merged
Only show use-pro deprecation message on top action input#67dominikschubert merged 1 commit intomainfrom
dominikschubert merged 1 commit intomainfrom
Conversation
|
The ephemeral instance for the application preview has been shut down |
joe4dev
approved these changes
Apr 2, 2026
Member
joe4dev
left a comment
There was a problem hiding this comment.
Will the deprecation warning be shown when use-pro is set explicitly, now that the deprecation message is removed?
Member
Author
Yes. The deprecation message is still available here: Line 22 in 2e0e140 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #66
The
use-prodeprecation message was shown even when users of the action didn't explicitly set the input, which was not the intended behavior.use-prodeprecation message shown?Root cause:
setup-localstack/action.yml
Line 122 in 2e0e140
In the "sub"-action, the value will always be set, so that always triggered the deprecation message.
Changes
use-proshould now only be displayed when a user explicitly set it.