Skip to content

Only show use-pro deprecation message on top action input#67

Merged
dominikschubert merged 1 commit intomainfrom
fix-deprecation-message
Apr 2, 2026
Merged

Only show use-pro deprecation message on top action input#67
dominikschubert merged 1 commit intomainfrom
fix-deprecation-message

Conversation

@dominikschubert
Copy link
Copy Markdown
Member

@dominikschubert dominikschubert commented Apr 2, 2026

Motivation

Fixes #66

The use-pro deprecation message was shown even when users of the action didn't explicitly set the input, which was not the intended behavior.

Situation Image used use-pro deprecation message shown?
User omits use-pro localstack/localstack-pro no (before this PR this was also unintentionally yes)
User sets use-pro: true localstack/localstack-pro yes
User sets use-pro: false localstack/localstack yes

Root cause:

"use-pro": ${{ toJSON(inputs.use-pro) }},

In the "sub"-action, the value will always be set, so that always triggered the deprecation message.

Changes

  • Deprecation message for use-pro should now only be displayed when a user explicitly set it.

@dominikschubert dominikschubert self-assigned this Apr 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

The ephemeral instance for the application preview has been shut down

@dominikschubert dominikschubert requested a review from joe4dev April 2, 2026 08:22
@dominikschubert dominikschubert marked this pull request as ready for review April 2, 2026 08:24
Copy link
Copy Markdown
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the deprecation warning be shown when use-pro is set explicitly, now that the deprecation message is removed?

@dominikschubert
Copy link
Copy Markdown
Member Author

Will the deprecation warning be shown when use-pro is set explicitly, now that the deprecation message is removed?

Yes. The deprecation message is still available here:

deprecationMessage: 'use-pro is deprecated and will be removed in a future release. The pro image is now the default.'

@dominikschubert dominikschubert merged commit e23ef40 into main Apr 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use-pro warning is unavoidable

2 participants