Skip to content

feat: allow tag filtering options#6997

Open
karthikeya-333 wants to merge 4 commits intolouislam:masterfrom
karthikeya-333:tag-filter-options
Open

feat: allow tag filtering options#6997
karthikeya-333 wants to merge 4 commits intolouislam:masterfrom
karthikeya-333:tag-filter-options

Conversation

@karthikeya-333
Copy link
Copy Markdown
Contributor

@karthikeya-333 karthikeya-333 commented Feb 20, 2026

Summary

In this pull request, the following changes are made:

Added tag filtering options for monitor tags (Match Any or Match All)

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🔍 Any UI changes adhere to visual style of this project.
  • 🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 I added or updated automated tests where appropriate.
  • 📄 Documentation updates are included (if applicable).
  • 🧰 Dependency updates are listed and explained.
  • ⚠️ CI passes and is green.

Screenshots for Visual Changes

Before:
image

After:
image
image

  • UI Modifications: Add a section to select one of the filter options. Based on the selected button, the tags get filtered.

@karthikeya-333 karthikeya-333 marked this pull request as ready for review February 20, 2026 19:03
@github-actions github-actions bot added the pr:needs review this PR needs a review by maintainers or other community members label Feb 20, 2026
@CommanderStorm
Copy link
Copy Markdown
Collaborator

I don't quite like the way the UI looks. those buttons look farly off.

How about we change this to be a clickable link type of thing?
I wipped this up in gemini (as design inspiration), what do you think?

image

@karthikeya-333
Copy link
Copy Markdown
Contributor Author

karthikeya-333 commented Feb 20, 2026

So when you click the link, it would simply toggle between "Match Any" and "Match All". Right? This looks cleaner.

@CommanderStorm
Copy link
Copy Markdown
Collaborator

Yes, a clickable button, styled with btn btn-link

Docs:

For an extra nice UI, I think moving the check boxes to the left would likely also be a nice touch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:needs review this PR needs a review by maintainers or other community members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow changing Multiple Tags selection from OR to AND

2 participants