Skip to content

fix: group reordering causes incorrect expansion state of adjacent groups when pausing/resuming#7033

Open
speedcoder430 wants to merge 5 commits intolouislam:masterfrom
speedcoder430:fix-group-expansion-state-on-reorder
Open

fix: group reordering causes incorrect expansion state of adjacent groups when pausing/resuming#7033
speedcoder430 wants to merge 5 commits intolouislam:masterfrom
speedcoder430:fix-group-expansion-state-on-reorder

Conversation

@speedcoder430
Copy link
Copy Markdown

Summary

In this pull request, the following changes are made:

  • Changed :key="index" to :key="item.id" in MonitorListItem.vue child group rendering, because using array index as the Vue :key caused component instances to retain stale isCollapsed state when the sorted list reordered after pausing/resuming a group.

  • Fixed the IPv6 bracket-stripping test in test-util-server.js to handle environments where IPv6 is reachable, because assert.rejects fails when the ping succeeds.

  • Resolves Group reordering causes incorrect expansion state of adjacent groups when pausing/resuming #6781

Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • ⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
  • 🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🔍 Any UI changes adhere to visual style of this project.
  • 🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • 🤖 I added or updated automated tests where appropriate.
  • 📄 Documentation updates are included (if applicable).
  • 🧰 Dependency updates are listed and explained.
  • ⚠️ CI passes and is green.

Screenshots for Visual Changes

N/A — no visual changes. The fix is a :key binding correction that preserves existing UI behavior (group expansion state stays with the correct group during list reordering).

@github-actions
Copy link
Copy Markdown
Contributor

Hello and thanks for lending a paw to Uptime Kuma! 🐻👋
As this is your first contribution, please be sure to check out our Pull Request guidelines.
In particular: - Mark your PR as Draft while you’re still making changes - Mark it as Ready for review once it’s fully ready
If you have any design or process questions, feel free to ask them right here in this pull request - unclear documentation is a bug too.

@speedcoder430 speedcoder430 changed the title fix: group reordering causes incorrect expansion state of adjacent gr… fix: group reordering causes incorrect expansion state of adjacent groups when pausing/resuming Feb 23, 2026
Copy link
Copy Markdown
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, will need to manually test this though before merging.

Could you fix the linting error?

@speedcoder430
Copy link
Copy Markdown
Author

speedcoder430 commented Feb 23, 2026

Change LGTM, will need to manually test this though before merging.

Could you fix the linting error?

Hi @CommanderStorm , Thanks for your kind feedback. I fixed the linting error. Please review the code on your end again. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Group reordering causes incorrect expansion state of adjacent groups when pausing/resuming

2 participants