You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In this pull request, the following changes are made:
Changed :key="index" to :key="item.id" in MonitorListItem.vue child group rendering, because using array index as the Vue :key caused component instances to retain stale isCollapsed state when the sorted list reordered after pausing/resuming a group.
Fixed the IPv6 bracket-stripping test in test-util-server.js to handle environments where IPv6 is reachable, because assert.rejects fails when the ping succeeds.
Please follow this checklist to avoid unnecessary back and forth (click to expand)
⚠️ If there are Breaking change (a fix or feature that alters existing functionality in a way that could cause issues) I have called them out
🧠 I have disclosed any use of LLMs/AI in this contribution and reviewed all generated content.
I understand that I am responsible for and able to explain every line of code I submit.
🔍 Any UI changes adhere to visual style of this project.
🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
🤖 I added or updated automated tests where appropriate.
📄 Documentation updates are included (if applicable).
🧰 Dependency updates are listed and explained.
⚠️ CI passes and is green.
Screenshots for Visual Changes
N/A — no visual changes. The fix is a :key binding correction that preserves existing UI behavior (group expansion state stays with the correct group during list reordering).
Hello and thanks for lending a paw to Uptime Kuma! 🐻👋
As this is your first contribution, please be sure to check out our Pull Request guidelines.
In particular: - Mark your PR as Draft while you’re still making changes - Mark it as Ready for review once it’s fully ready
If you have any design or process questions, feel free to ask them right here in this pull request - unclear documentation is a bug too.
speedcoder430
changed the title
fix: group reordering causes incorrect expansion state of adjacent gr…
fix: group reordering causes incorrect expansion state of adjacent groups when pausing/resuming
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this pull request, the following changes are made:
Changed
:key="index"to:key="item.id"inMonitorListItem.vuechild group rendering, because using array index as the Vue:keycaused component instances to retain staleisCollapsedstate when the sorted list reordered after pausing/resuming a group.Fixed the IPv6 bracket-stripping test in
test-util-server.jsto handle environments where IPv6 is reachable, becauseassert.rejectsfails when the ping succeeds.Resolves Group reordering causes incorrect expansion state of adjacent groups when pausing/resuming #6781
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.
Screenshots for Visual Changes
N/A — no visual changes. The fix is a
:keybinding correction that preserves existing UI behavior (group expansion state stays with the correct group during list reordering).