fix: handle NoSuchMethodError for isMainMethodCandidate() on older JD…#622
Merged
wenytang-ms merged 3 commits intomainfrom Mar 31, 2026
Merged
Conversation
…T Core Catch NoSuchMethodError when calling SourceMethod.isMainMethodCandidate() in ResolveMainClassHandler and ResolveMainMethodHandler. This method was added in JDT Core 3.36 and is unavailable on older versions, causing the debugger to fail entirely when resolving main classes. Fixes microsoft/vscode-java-debug#1598 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wenytang-ms
requested review from
chagong,
jdneo and
testforstephen
as code owners
chagong
approved these changes
Mar 31, 2026
There was a problem hiding this comment.
Pull request overview
This PR improves backward compatibility with older Eclipse JDT Core versions by preventing debugger failures when SourceMethod.isMainMethodCandidate() is unavailable (added in JDT Core 3.36), allowing main-class/main-method resolution to continue via fallback logic.
Changes:
- Wrap calls to
SourceMethod.isMainMethodCandidate()intry/catch (NoSuchMethodError)in main-method resolution. - Add a fallback path in main-class resolution to use
IMethod.isMainMethod()whenisMainMethodCandidate()is missing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
com.microsoft.java.debug.plugin/.../ResolveMainMethodHandler.java |
Prevents crashes during per-type method scanning by catching NoSuchMethodError around isMainMethodCandidate(). |
com.microsoft.java.debug.plugin/.../ResolveMainClassHandler.java |
Prevents crashes during search-based main-method detection by catching NoSuchMethodError and falling back to isMainMethod(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
....plugin/src/main/java/com/microsoft/java/debug/plugin/internal/ResolveMainMethodHandler.java
Show resolved
Hide resolved
...g.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/ResolveMainClassHandler.java
Show resolved
Hide resolved
wenytang-ms
deleted the
fix/handle-nosuchmethoderror-isMainMethodCandidate
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…T Core
Catch NoSuchMethodError when calling SourceMethod.isMainMethodCandidate() in ResolveMainClassHandler and ResolveMainMethodHandler. This method was added in JDT Core 3.36 and is unavailable on older versions, causing the debugger to fail entirely when resolving main classes.
Fixes microsoft/vscode-java-debug#1598