[Bug]: acceptShareAction in the pending shares view uses file_id instead of share_id

[albanbruder]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

nextcloud=# SELECT id, file_source FROM oc_share WHERE uid_owner = 'admin' AND accepted = '0';
  id   | file_source
-------+-------------
 57212 |          29

When trying to accept the share in the /apps/files/pendingshares view a POST request to the /ocs/v2.php/apps/files_sharing/api/v1/shares/pending/29 endpoint is made. This request is using the file_source instead of the oc_share.id, and results in a 404 response.

Manually accepting the share using the oc_share.id does work:

curl -u "[redacted]" -H "OCS-APIRequest: true" -X POST "https://[redacted]/ocs/v2.php/apps/files_sharing/api/v1/shares/pending/57212"

Steps to reproduce

1. Ensure Accept shares from other accounts and groups by default is disabled at /settings/user/sharing
2. Create an internal share
3. Try to accept the share at /apps/files/pendingshares

Expected behavior

The share should be accepted.

Nextcloud Server version

33

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Nginx

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 31 to 32)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

{
    "system": {
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "[redacted]"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "version": "33.0.0.16",
        "overwrite.cli.url": "[redacted]",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "maintenance": false,
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "updater.server.url": "***REMOVED SENSITIVE VALUE***",
        "updater.release.channel": "stable",
        "default_phone_region": "DE",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379,
            "password": "***REMOVED SENSITIVE VALUE***"
        },
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "sendmail",
        "mail_sendmailmode": "pipe",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "upgrade.disable-web": true,
        "debug": false,
        "profile.enabled": false,
        "loglevel": 2,
        "logfile": "\/var\/log\/nextcloud\/nextcloud.log",
        "davstorage.request_timeout": 60,
        "sharing.enable_share_mail": true,
        "sharing.allow_disabled_password_enforcement_groups": true,
        "sharing.minSearchStringLength": 3,
        "sharing.maxAutocompleteResults": 10,
        "trashbin_retention_obligation": "auto, 30",
        "maintenance_window_start": "2",
        "files.chunked_upload.max_size": 10485760,
        "app_install_overwrite": [],
        "token_auth_enforced": true,
        "allowed_admin_ranges": [
            "[redacted]"
        ],
        "auth.webauthn.enabled": false
    }
}

List of activated Apps

Enabled:
  - activity: 6.0.0-dev.0
  - announcementbanner: 2.3.1
  - bruteforcesettings: 6.0.0-dev.0
  - calendar: 6.2.1
  - circles: 33.0.0
  - cloud_federation_api: 1.17.0
  - comments: 1.23.0
  - contacts: 8.4.2
  - contactsinteraction: 1.14.1
  - dashboard: 7.13.0
  - dav: 1.36.0
  - deck: 1.17.0
  - federatedfilesharing: 1.23.0
  - federation: 1.23.0
  - files: 2.5.0
  - files_accesscontrol: 4.0.0
  - files_downloadlimit: 5.1.0-dev.0
  - files_pdfviewer: 6.0.0-dev.0
  - files_sharing: 1.25.2
  - files_trashbin: 1.23.0
  - files_versions: 1.26.0
  - groupfolders: 21.0.6
  - impersonate: 4.0.0
  - logreader: 6.0.0
  - lookup_server_connector: 1.21.0
  - notes: 4.13.1
  - notifications: 6.0.0
  - oauth2: 1.21.0
  - onlyoffice: 10.0.0
  - photos: 6.0.0-dev.0
  - polls: 8.6.3
  - privacy: 5.0.0-dev.0
  - profile: 1.2.0
  - provisioning_api: 1.23.0
  - recommendations: 6.0.0-dev.0
  - related_resources: 4.0.0-dev.0
  - serverinfo: 5.0.0-dev.0
  - settings: 1.16.0
  - sharebymail: 1.23.0
  - survey_client: 5.0.0-dev.0
  - systemtags: 1.23.0
  - tasks: 0.17.1
  - text: 7.0.0-dev.3
  - theming: 2.8.0
  - theming_customcss: 1.20.0
  - twofactor_backupcodes: 1.22.0
  - updatenotification: 1.23.0
  - user_saml: 7.1.4
  - user_status: 1.13.0
  - user_usage_report: 4.0.0
  - viewer: 6.0.0-dev.0
  - whiteboard: 1.5.7
  - workflowengine: 2.15.0
Disabled:
  - admin_audit: 1.23.0
  - app_api: 33.0.0 (installed 4.0.3)
  - encryption: 2.21.0
  - files_external: 1.25.1 (installed 1.22.0)
  - files_reminders: 1.6.0 (installed 1.3.0)
  - firstrunwizard: 6.0.0-dev.0 (installed 6.0.0-dev.0)
  - nextcloud_announcements: 5.0.0 (installed 1.14.0)
  - password_policy: 5.0.0-dev.0 (installed 2.0.0)
  - support: 5.0.0 (installed 5.0.0)
  - suspicious_login: 11.0.0-dev.0
  - twofactor_nextcloud_notification: 7.0.0
  - twofactor_totp: 15.0.0-dev.0 (installed 15.0.0-dev.0)
  - user_ldap: 1.24.0 (installed 1.23.0)
  - weather_status: 1.13.0 (installed 1.5.0)
  - webhook_listeners: 1.5.0 (installed 1.1.0-dev)

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

no relevant logs

Additional info

No response