Open
Conversation
Ports [https://github.com/nodejs/node/tree/main/test/js-native-api/test_dataview](test_dataview) from Node.js test suite to the CTS. This test contains an experimental feature `SharedArrayBuffer`, resulting in usage of `add_node_api_cts_experimental_addon()`. Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
bavulapati
commented
Mar 29, 2026
| function(add_node_api_cts_experimental_addon ADDON_NAME) | ||
| cmake_parse_arguments(PARSE_ARGV 1 ARG "" "" "SOURCES") | ||
| add_node_api_cts_addon(${ADDON_NAME} ${ARG_SOURCES}) | ||
| add_node_api_cts_addon(${ADDON_NAME} ${ARGN}) |
Author
There was a problem hiding this comment.
The PARSE_ARGV usage isn't picking the sources correctly. We can just do what we do in the add_node_cts_addon.
kraenhansen
approved these changes
Mar 30, 2026
Contributor
|
Reviewed: C file is a verbatim copy of upstream, |
node_api_is_sharedarraybuffer is added in v24.9.0 https://nodejs.org/api/n-api.html#node-api-is-sharedarraybuffer Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
Author
|
@legendecas Fixed the CI issue. Can we run the tests again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
https://github.com/nodejs/node/tree/main/test/js-native-api/test_dataview from Node.js test suite to the CTS.
This test contains an experimental feature
SharedArrayBuffer, resulting in usage ofadd_node_api_cts_experimental_addon().