This repository was archived by the owner on Oct 15, 2020. It is now read-only.
tools,doc: apilinks should handle root scenarios#589
Closed
kfarnung wants to merge 0 commit intonodejs:masterfrom
Closed
tools,doc: apilinks should handle root scenarios#589kfarnung wants to merge 0 commit intonodejs:masterfrom
kfarnung wants to merge 0 commit intonodejs:masterfrom
Conversation
addaleax
approved these changes
Sep 6, 2018
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM
Can this be upstreamed (with tools,doc: as the prefix)?
digitalinfinity
approved these changes
Sep 6, 2018
Contributor
Author
|
Thanks @addaleax, fixed the title upstream: nodejs/node#22721 EDIT: I had forgotten to link this initially, sorry about that! |
kfarnung
changed the title
Contributor
Author
Contributor
Author
Contributor
Author
|
Seeing consistent, but unrelated macOS failures, opened #590 to track. |
kfarnung
added a commit
that referenced
this pull request
Sep 6, 2018
* Prevent crash when setting root properties * Allow return outside of function PR-URL: #589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Sep 11, 2018
* Prevent crash when setting root properties * Allow return outside of function PR-URL: nodejs#589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of nodejs/node#22721 which I'm in the process of landing upstream.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes