make with -j hangs

[devsnek]

[thefourtheye]

Preliminary analysis with git bisect says it could be because of 5d8373a. I'll check again.

[targos]

I think @refack mentioned #23182 as the fix. Can you try with it?

[thefourtheye]

Actually, reverting 5d8373a makes it work for me.

---

@targos Sure, I'll apply that and try now.

[thefourtheye]

#23182 didn't fix it for me.

[danbev]

I ran into this yesterday but I don't think I've seen it after doing a make clean. Not sure if that is a coincidence or not but could be worth trying.

[thefourtheye]

@danbev I can confirm that make clean fixes this problem for me. I'll close the PR.

[cjihrig]

I've run into this. make clean fixed the problem the first time I rebuilt it, but subsequent builds hung again. Maybe we should reopen and land #23257.

[thefourtheye]

@cjihrig Reopened #23257. Even my rebuild hung.

[refack]

Could anyone who can repro this run make with -d and post the (probably huge) output?

P.S. I see @devsnek is using macOS? what other OSes (and make versions) does this repro with?

[devsnek]

@refack log is a bit long (1.1GB output) but it appears to be an infinite loop of Pruning file

[refack]

refack log is a bit long (1.1GB output) but it appears to be an infinite loop of Pruning file

Thanks, I think this will be consistently failing on macOS, so I'll investigate.
Ironically the main reason for the change was to fix #22006, but in order to workaround that issue we now run make -j1 on our macOS CI workers, so I missed this regression.