Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first. Also disable the
readableside of thepushStreamsince there should never be any data incoming.I'm not able to make a test since technically what we were doing was fine (and works with our own client) but the browsers seem a bit too strict.
Fixes: #20992
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes