Skip to content

http2: delay closing stream#20997

Closed
apapirovski wants to merge 1 commit intonodejs:masterfrom
apapirovski:fix-http2-push
Closed

http2: delay closing stream#20997
apapirovski wants to merge 1 commit intonodejs:masterfrom
apapirovski:fix-http2-push

Conversation

@apapirovski
Copy link
Copy Markdown
Contributor

Delay automatically closing the stream with setImmediate in order to allow any pushStreams to be sent first. Also disable the readable side of the pushStream since there should never be any data incoming.

I'm not able to make a test since technically what we were doing was fine (and works with our own client) but the browsers seem a bit too strict.

Fixes: #20992

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

http2 pushPromise in 10.2.0+

4 participants