Skip to content

process: group main thread execution preparation code#26000

Closed
joyeecheung wants to merge 3 commits intonodejs:masterfrom
joyeecheung:pre-execute
Closed

process: group main thread execution preparation code#26000
joyeecheung wants to merge 3 commits intonodejs:masterfrom
joyeecheung:pre-execute

Conversation

@joyeecheung
Copy link
Copy Markdown
Member

@joyeecheung joyeecheung commented Feb 8, 2019

This patch groups the preparation of main thread execution into
prepareMainThreadExecution() and removes the cluster IPC
setup in worker thread bootstrap since clusters do not use
worker threads for its implementation and it's unlikely to change.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants