win,v8: Support for MSVS 2015 in v0.12#2843
Closed
joaocgreis wants to merge 9 commits intonodejs:v0.12from
Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes all of the commits needed to support MSVS 2015 and MSI generation with it, and a manifest update to enable
os.release()to report the correct version on Windows 10. All of this is already in v0.10.I had to mark
==and!=as const inzone-allocator.h(3rd commit from HEAD). That was done upstream in https://chromium.googlesource.com/v8/v8.git/+/f9e4527f32c2c268cb79428c74ea9703e9db3aec . I did not backport the full commit because it changes other parts that are not needed. @nodejs/v8 any issues with this?Fixes nodejs/node-v0.x-archive#25896
@rvagg I know it's late, but any chance of including in v0.12.8?
cc @nodejs/platform-windows @nodejs/lts