Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
577 commits
Select commit Hold shift + click to select a range
1d6bed9
src: fix label indentation
Trott Nov 21, 2020
a184e51
tools: bump cpplint.py to 1.5.2
Trott Nov 21, 2020
5580bd7
tools: refloat 7 Node.js patches to cpplint.py
Trott Oct 9, 2020
b5d9bd5
src: update node.rc file description
devsnek Nov 20, 2020
abe3456
doc: cleanup events.md structure
jasnell Nov 12, 2020
f5d2374
deps: upgrade npm to 7.0.13
ruyadorno Nov 20, 2020
513764b
events: graduate Event, EventTarget, AbortController
jasnell Nov 3, 2020
cb5acc8
doc: add missing version to update cmd
ruyadorno Nov 20, 2020
0c3e100
doc: stabilize subpath patterns
guybedford Nov 19, 2020
3811473
tools: update ESLint to 7.14.0
cjihrig Nov 21, 2020
267a6e6
tools: enable no-nonoctal-decimal-escape lint rule
cjihrig Nov 21, 2020
5325376
doc: fix --experimental-wasm-modules text location
cjihrig Nov 21, 2020
4388c14
test: fix missed warning for non-experimental AbortController
jasnell Nov 23, 2020
767070c
deps: upgrade npm to 7.0.14
nlf Nov 23, 2020
68795f9
test: improve test coverage SourceMap API
juanarbol Nov 11, 2020
d4501b1
process: refactor to use more primordials
aduh95 Nov 15, 2020
7b5b8ef
2020-11-24, Version 15.3.0 (Current)
codebytere Nov 22, 2020
219332e
2020-11-24, Version 12.20.0 'Erbium' (LTS)
MylesBorins Nov 16, 2020
4f0f2e7
crypto: fix "Invalid JWK" error messages
panva Nov 20, 2020
05847a7
lib: refactor primordials.uncurryThis
aduh95 Nov 21, 2020
866b1e6
quic: refactor to use more primordials
aduh95 Nov 15, 2020
757d7ba
doc: fix typo in events.md
lpinca Nov 22, 2020
4c97325
deps: V8: cherry-pick 86991d0587a1
Nov 25, 2020
2b21a31
doc: adding example to Buffer.isBuffer method
ntedgi Nov 23, 2020
49abda7
benchmark : changed `fstat` to `fstatSync`
Narasimha1997 Nov 21, 2020
c19ea7b
test: increase coverage for util.inspect()
Trott Nov 22, 2020
fa51665
tools: bump cpplint to 1.5.3
Trott Nov 23, 2020
6eec858
tools: refloat 7 Node.js patches to cpplint.py
Trott Oct 9, 2020
0a23d65
tools: use using-declaration consistently
danbev Nov 24, 2020
8ba65b5
test: fix flaky sequential/test-fs-watch
Trott Nov 24, 2020
709b339
assert: refactor to use more primordials
aduh95 Nov 19, 2020
c12497e
build: fix typo in Makefile
RaisinTen Nov 19, 2020
b4c2ff5
policy: refactor to use more primordials
aduh95 Nov 15, 2020
8d6c2f2
fs: refactor to use more primordials
aduh95 Nov 19, 2020
b938f88
fs: pass ERR_DIR_CLOSED asynchronously to dir.close
Lxxyx Nov 24, 2020
0ac2d0f
doc: add table header in intl.md
Trott Nov 25, 2020
2999845
tools: fix undeclared identifier FALSE
aduh95 Nov 25, 2020
6ca7312
tty: refactor to use more primordials
Lxxyx Nov 26, 2020
9bf12df
fs: move method definition from header
yashLadha Nov 25, 2020
2365115
test: replace anonymous functions by arrows
Nov 14, 2020
f34866a
tools: update highlight.js to 10.1.2
MylesBorins Nov 28, 2020
dedd061
http: enable call chaining with setHeader()
PoojaDurgad Nov 2, 2020
709ada5
deps: upgrade npm to 7.0.15
ruyadorno Nov 27, 2020
8ff2501
module: add isPreloading indicator
jasnell Nov 25, 2020
9cf2341
doc: add process for handling premature disclosure
mhdawson Nov 17, 2020
cb023a3
tools: update stability index linking logic
Trott Nov 26, 2020
2dc6bf0
src: use ToLocal in DeserializeProperties
danbev Nov 26, 2020
976d6a9
test: fix typo in comment
inokawa Nov 29, 2020
e6e7084
os: refactor to use more primordials
aduh95 Nov 20, 2020
dbfb10d
v8: refactor to use more primordials
aduh95 Nov 20, 2020
1d82d1e
perf_hooks: refactor to use more primordials
aduh95 Nov 21, 2020
83166fb
http2: check write not scheduled in scope destructor
davedoesdev Nov 23, 2020
09fd8f1
errors: display original symbol name
Nov 8, 2020
9e446b3
worker: add experimental BroadcastChannel
jasnell Nov 26, 2020
7d45dd9
buffer: refactor to use more primordials
aduh95 Nov 18, 2020
780fcb4
https: add abortcontroller test
benjamingr Nov 28, 2020
1ed72f6
timers: reject with AbortError on cancellation
benjamingr Nov 29, 2020
4a741b8
tls: permit null as a cipher value
Trott Nov 29, 2020
ef8d0e9
events: support signal in EventTarget
benjamingr Nov 25, 2020
c91e608
test: fix test-worker-broadcastchannel-wpt
Trott Dec 2, 2020
825029e
repl: refactor to use more primordials
aduh95 Nov 16, 2020
f066ae4
tls: refactor to use more primordials
aduh95 Nov 17, 2020
325a1fc
worker: refactor to use more primordials
aduh95 Nov 16, 2020
187a862
path: refactor to use more primordials
aduh95 Nov 18, 2020
99f6167
benchmark,child_process: remove failing benchmark parameter
aduh95 Nov 27, 2020
393a1fe
src: use transferred consistently
danbev Dec 1, 2020
a897a25
querystring: refactor to use more primordials
aduh95 Nov 18, 2020
f7dd330
child_process: refactor to use more primordials
Lxxyx Nov 25, 2020
e4614e8
src: rename AliasedBufferInfo->AliasedBufferIndex
danbev Dec 1, 2020
ff28ab7
src: remove some duplication in DeserializeProps
danbev Dec 1, 2020
3604fad
module: refactor to use more primordials
aduh95 Nov 21, 2020
e4d570f
zlib: refactor to use more primordials
aduh95 Nov 20, 2020
d1e4d34
test: skip flaky parts of broadcastchannel test on Windows
Trott Dec 4, 2020
e074bee
dgram: refactor to use more primordials
aduh95 Nov 19, 2020
ed6e71a
readline: refactor to use more primordials
aduh95 Nov 15, 2020
1729ba7
tools: remove bashisms from release script
aduh95 Nov 14, 2020
8973075
tools: remove bashisms from macOS release scripts
aduh95 Nov 14, 2020
0fd121e
stream: add FileHandle support to Read/WriteStream
mmomtchev Nov 2, 2020
e929d1f
src: fix node version
mscdex Dec 4, 2020
0905663
vm: add `SafeForTerminationScope`s for SIGINT interruptions
addaleax Dec 1, 2020
2ce2b48
tools: bump cpplint to 1.5.4
Trott Nov 30, 2020
5477969
tools: refloat 7 Node.js patches to cpplint.py
Trott Oct 9, 2020
20de5f7
child_process: add AbortSignal support
benjamingr Nov 28, 2020
2f49720
doc: add version metadata to timers/promises
cjihrig Dec 4, 2020
5fa7c2a
doc: add Powershell oneliner to get Windows version
saitonakamura Nov 6, 2019
d2e4b98
test: increase coverage for readline
Lxxyx Dec 4, 2020
ff048bd
buffer: refactor to use primordials instead of Array#reduce
aduh95 Dec 4, 2020
537da19
test: fix bootstrap test
benjamingr Dec 6, 2020
f178c5a
test: fix flaky test-http2-respond-file-error-pipe-offset
Trott Nov 28, 2020
5122456
test: fix comment misspellings of transferred
Trott Dec 3, 2020
5bd1eec
stream: support abort signal
benjamingr Nov 9, 2020
7e5fc9c
lib: fix typo in internal/errors.js
RaisinTen Dec 7, 2020
4027e36
string_decoder: refactor to use more primordials
aduh95 Nov 21, 2020
b5bb094
http2: refactor to use more primordials
aduh95 Nov 21, 2020
c83e599
lib: add uncurried accessor properties to `primordials`
ExE-Boss Nov 30, 2020
23f4b6e
worker: refactor to use more primordials
aduh95 Dec 4, 2020
5f1bf80
tools: upgrade to @babel/eslint-parser 7.12.1
aduh95 Nov 29, 2020
0869b82
net: refactor to use more primordials
aduh95 Nov 17, 2020
bf31d3c
tools: enable no-unused-expressions lint rule
targos Nov 24, 2020
96b4950
dns: refactor to use more primordials
aduh95 Nov 20, 2020
6d3775e
doc: provide more context on techinical values
mhdawson Nov 20, 2020
ca8eb79
test: fix child-process-pipe-dataflow
santigimeno Dec 3, 2020
a45f622
test: add SIGTRAP to test-signal-handler
Dec 3, 2020
7a39d89
test: check null proto-of-proto in util.inspect()
Trott Dec 5, 2020
e31a99f
src: add missing context scopes
addaleax Dec 6, 2020
8dbeac6
tools: update doc tool dependencies
targos Dec 6, 2020
13e2170
doc: document ABORT_ERR code
benjamingr Nov 29, 2020
344a544
src: use using declarations consistently
danbev Dec 3, 2020
748d98a
src: remove identical V macro
danbev Dec 7, 2020
ea6df03
src: fix indentation in memory_tracker-inl.h
danbev Dec 7, 2020
9b23777
test: fix flaky test-repl
Trott Dec 6, 2020
348b7a9
2020-12-09, Version 15.4.0 (Current)
danielleadams Dec 7, 2020
8d8c7af
deps: upgrade npm to 7.1.0
ruyadorno Dec 4, 2020
27a63ee
doc: add RaisinTen as a triager
RaisinTen Dec 6, 2020
514da38
tools: update ESLint to 7.15.0
cjihrig Dec 6, 2020
a26ae70
tools: enable no-unsafe-optional-chaining lint rule
cjihrig Dec 6, 2020
87dc152
src: fix node version
richardlau Dec 9, 2020
8b69724
doc: reword POSIX threads text in addons.md
Trott Dec 7, 2020
5dd58d0
test: increase execFile abort coverage
shootermv Dec 7, 2020
8065883
inspector: refactor to use more primordials
aduh95 Nov 21, 2020
040a27a
stream: support abortsignal in constructor
benjamingr Dec 7, 2020
72b07e4
doc: update terminology
mhdawson Dec 10, 2020
7e5bf48
build,lib,test: change whitelist to allowlist
targos Dec 6, 2020
f49cef5
src: add typedef for CleanupHookCallback callback
danbev Dec 8, 2020
348a3ad
src: introduce convenience node::MakeSyncCallback()
nicstange Nov 29, 2020
c53ba1f
perf_hooks: invoke performance_entry_callback via MakeSyncCallback()
nicstange Nov 29, 2020
1ea4b83
Revert "perf_hooks: make PerformanceObserver an AsyncResource"
nicstange Nov 29, 2020
ef0f5b1
test: add test for async contexts in PerformanceObserver
ZauberNerd Dec 2, 2020
7faeddf
tools: update ini in tools/node-lint-md-cli-rollup
MylesBorins Dec 10, 2020
f51a0e4
deps: upgrade npm to 7.1.1
ruyadorno Dec 9, 2020
743ee9d
src: allow preventing SetPrepareStackTraceCallback
codebytere Dec 8, 2020
d50b2ff
doc: note v15.0.0 changed default --unhandled-rejections=throw
kaizhu256 Dec 3, 2020
738cd60
child_process: add signal support to spawn
benjamingr Dec 7, 2020
f78da00
util: fix module prefixes during inspection
BridgeAR Nov 19, 2020
1e66509
util: fix instanceof checks with null prototypes during inspection
BridgeAR Nov 19, 2020
5a3c411
deps: upgrade npm to 7.1.2
darcyclarke Dec 11, 2020
78d1f8d
tls: forward new SecureContext options
mildsunrise Dec 6, 2020
7c702f8
test: increased externalized string length
codebytere Dec 9, 2020
e28f23f
doc: edit addon text about event loop blocking
Trott Dec 8, 2020
88dfecc
worker: refactor MessagePort entanglement management
addaleax Dec 1, 2020
7069d22
src: guard against env != null in node_errors.cc
addaleax Dec 6, 2020
d313bf7
src: add way to get IsolateData and allocator from Environment
addaleax Dec 8, 2020
a91a95f
deps: V8: backport 4bf051d536a1
addaleax Dec 11, 2020
c6c8337
src: use correct outer Context’s microtask queue
addaleax Dec 8, 2020
2ef9a76
http: use objects with null prototype in Agent
targos Dec 6, 2020
2cd8350
test: make executable name more general
codebytere Dec 12, 2020
903998a
src: remove duplicate V macros in node_v8.cc
danbev Dec 9, 2020
f43d1ca
util: simplify constructor retrieval in inspect()
Trott Dec 10, 2020
ed3a4c8
test: increase coverage for net/blocklist
Lxxyx Dec 6, 2020
68b6c1a
doc: add PoojaDurgad to collaborators
PoojaDurgad Dec 14, 2020
67643e1
worker: fix broadcast channel SharedArrayBuffer passing
addaleax Dec 13, 2020
04e5418
doc: add v15.4.0 link to CHANGELOG.md
danielleadams Dec 9, 2020
752991d
build: fix make test-npm
ruyadorno Dec 3, 2020
850c466
doc: revise addon mulitple initializations text
Trott Dec 9, 2020
7c80817
test: remove test-http2-client-upload as flaky
Trott Dec 12, 2020
0a5969c
lib: make safe primordials safe to iterate
aduh95 Dec 4, 2020
45dbcbe
readline: cursorTo throw error on NaN
Lxxyx Dec 4, 2020
6837a6d
stream: accept iterable as a valid first argument
Lxxyx Dec 11, 2020
5a637e9
src: remove empty name check in node_env_var.cc
RaisinTen Nov 16, 2020
a9c0077
test: increase coverage for fs/dir read
Lxxyx Dec 4, 2020
91fe3de
doc: add license info to the README
iam-frankqiu Nov 26, 2020
a150926
2020-12-15, Version 14.15.2 'Fermium' (LTS)
BethGriggs Dec 10, 2020
0b3caad
doc: make explicit reverting node_version.h changes
richardlau Dec 9, 2020
44243e5
test: specify global object for globals
Trott Dec 13, 2020
3bd9b81
deps: update to c-ares 1.17.1
lxdicted Nov 21, 2020
b558075
doc: update url.md
aarock1234 Nov 17, 2020
4a6200e
doc: add issue reference to github pr template
chinmoy12c Dec 8, 2020
0e96dc1
tools: lint shell scripts
aduh95 Nov 10, 2020
d0b1b13
deps: upgrade npm to 7.2.0
MylesBorins Dec 16, 2020
b833305
deps: fix npm doctor tests for pre-release node
nlf Dec 15, 2020
548790a
deps: update patch and docs for openssl update
MylesBorins Dec 14, 2020
db3b2f6
deps: upgrade openssl sources to 1.1.1i
MylesBorins Dec 14, 2020
06c5b53
deps: various quic patches from akamai/openssl
tmshort Apr 12, 2019
b0d5bfe
deps: re-enable OPENSSL_NO_QUIC guards
jasnell Jun 24, 2020
e51267b
deps: update archs files for OpenSSL-1.1.1i
MylesBorins Dec 15, 2020
eb14b10
src: remove unnecessary ToLocalChecked call
danbev Dec 15, 2020
55e83cb
http: use `autoDestroy: true` in incoming message
dnlup May 19, 2020
6120028
http: reafactor incoming message destroy
dnlup Nov 24, 2020
70eaf55
http: fix lint error in incoming message
dnlup Dec 9, 2020
5ae9690
http: add comments in _http_incoming
dnlup Dec 9, 2020
f20a88f
http: remove trailing space
dnlup Dec 11, 2020
a6bf74e
http: use standard args order in IncomingMEssage onError
dnlup Dec 11, 2020
8154e47
http: add test for incomingmessage destroy
dnlup Dec 16, 2020
bc50577
doc: move Derek Lewis to emeritus
Trott Dec 14, 2020
32d58d7
tools: remove unused variable in configure.py
Trott Dec 15, 2020
f28715d
tools: fix release script
aduh95 Dec 16, 2020
6255973
doc: add note about timingSafeEqual for TypedArray
tniessen Nov 30, 2020
b49145f
2020-12-17, Version 14.15.3 'Fermium' (LTS)
BethGriggs Dec 17, 2020
36581f1
doc: add two tips for speeding the dev builds
mmomtchev Dec 9, 2020
565663e
test: increase coverage for worker
Lxxyx Dec 12, 2020
daa1322
build: run some workflows only on nodejs/node
targos Dec 14, 2020
ab895bd
stream: fix pipe deadlock when starting with needDrain
ronag Dec 18, 2020
82dd23f
repl: disable blocking completions by default
addaleax Dec 18, 2020
2070d5b
src: use correct microtask queue for checkpoints
addaleax Dec 19, 2020
fee3b89
benchmark: reduce code duplication
Trott Dec 18, 2020
775ce40
tools: fix update-eslint.sh
Dec 19, 2020
eefb424
tools: update ESLint to 7.16.0
Dec 19, 2020
ffc11c6
deps: upgrade npm to 7.3.0
ruyadorno Dec 18, 2020
b5fdb9e
doc: simplify worker_threads.md text
Trott Dec 17, 2020
6c25870
tools: fix release script sign function
aduh95 Dec 18, 2020
54e763d
fs: refactor to use optional chaining
Lxxyx Dec 15, 2020
1eb228e
lib: support BigInt in querystring.stringify
RaisinTen Dec 13, 2020
bea2252
doc: add remark about Collaborators discussion page
iam-frankqiu Dec 7, 2020
ce658bd
doc: update and run license-builder for Babel
targos Dec 14, 2020
aadb0bd
build: do not run GitHub actions for draft PRs
targos Nov 1, 2020
4d22dd3
test: increase coverage for stream
Lxxyx Dec 16, 2020
21f2e88
tools: fix make-v8.sh
richardlau Dec 21, 2020
fc8fcb0
src: remove unnecessary ToLocalChecked node_errors
danbev Dec 17, 2020
67b9ba9
test: increase abort logic coverage
shootermv Dec 18, 2020
656ce92
errors: eliminate all overhead for hidden calls
mmomtchev Oct 14, 2020
d90fa19
v8: fix native `serdes` constructors
ExE-Boss Dec 17, 2020
2723d2d
doc: fix AbortSignal example for stream.Readable
targos Dec 22, 2020
083abe2
tools: revise line in configure.py for clarity
Trott Dec 17, 2020
1623aff
lib: refactor to use more primordials in internal/histogram.js
RaisinTen Dec 9, 2020
f0a0e3c
child_process: clean event listener correctly
benjamingr Dec 7, 2020
80d2fbe
2020-12-22, Version 15.5.0 (Current)
targos Dec 21, 2020
6091a65
v8: refactor to use more primordials
aduh95 Dec 5, 2020
e22b751
doc: expand openssl instructions
mhdawson Dec 17, 2020
576a1b5
doc: remove "Related Issues" from pull request template
Trott Dec 21, 2020
2c8751c
doc: remove replication of GitHub template
Trott Dec 21, 2020
2d40e3f
lib: fix diagnostics_channel hasSubscribers error
Lxxyx Dec 22, 2020
3b0ecfc
test: redirect stderr EnvironmentWithNoESMLoader
danbev Dec 17, 2020
33d99b6
deps: V8: cherry-pick dfcdf7837e23
Dec 18, 2020
73a21e4
child_process: support AbortSignal in fork
benjamingr Dec 22, 2020
36c17e2
tools: use `is None` consistently in Python
Trott Dec 22, 2020
18fc50f
tools: call close() explicitly in genv8constants.py
Trott Dec 22, 2020
e068eec
tools: correct usage message for genv8constants.py
Trott Dec 22, 2020
f441c8b
doc: fix bugs in _construct() example
mkbaranovskyi Dec 14, 2020
88fb8e4
doc: document "http: lazy create IncomingMessage.headers"
ExE-Boss Dec 22, 2020
997f2fc
events: refactor to use more primordials
aduh95 Nov 17, 2020
40fc395
lib: make safe primordials safe to construct
aduh95 Dec 7, 2020
bd6f230
lib: add primordials.SafeStringIterator
aduh95 Dec 4, 2020
0187716
buffer: make FastBuffer safe to construct
aduh95 Dec 20, 2020
860c18b
benchmark: add simple https benchmark
puzpuzpuz Dec 23, 2020
5d28edc
url: refactor to use more primordials
aduh95 Nov 20, 2020
7303afb
lib: refactor to use primordials in internal/priority_queue.js
Lxxyx Dec 18, 2020
8c94aea
tools: update gyp-next to v0.7.0
targos Dec 19, 2020
9df3b76
doc: document return value of https.request
mcgitty Dec 3, 2020
c4cbdfa
lib: refactor to use more primordials in internal/encoding.js
RaisinTen Dec 11, 2020
4d3e87d
doc: use _code name_ rather than _codename_
Trott Dec 23, 2020
73b8909
test: increase runInAsyncScope() coverage
Trott Dec 24, 2020
75afb6c
test: improve coverage for util.inspect() with classes
Trott Dec 25, 2020
245159f
tools: revise install.py for minor improvements
Trott Dec 25, 2020
4e038d9
doc: correct callback parameter type for createPushResponse()
Trott Dec 25, 2020
0878d4d
doc: alphabetize http response properties
Trott Dec 25, 2020
4905501
quic,timers: refactor to use validateAbortSignal
Lxxyx Dec 22, 2020
acaa58e
http: remove dead code from internal/http.js
Lxxyx Dec 25, 2020
6c50d74
build: do not "exit" a script meant to be "source"d
fdgonthier Oct 6, 2020
aabbf30
https: refactor to use more primordials
aduh95 Nov 17, 2020
2010bea
Revert "http: use `autoDestroy: true` in incoming message"
dnlup Dec 27, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
1 change: 1 addition & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ indent_size = 2
indent_style = space
insert_final_newline = true
trim_trailing_whitespace = true
quote_type = single

[vcbuild.bat]
end_of_line = crlf
Expand Down
16 changes: 13 additions & 3 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ const ModuleFindPath = Module._findPath;
const hacks = [
'eslint-plugin-node-core',
'eslint-plugin-markdown',
'babel-eslint',
'@babel/eslint-parser',
'@babel/plugin-syntax-class-properties',
];
Module._findPath = (request, paths, isMain) => {
const r = ModuleFindPath(request, paths, isMain);
Expand All @@ -37,8 +38,14 @@ Module._findPath = (request, paths, isMain) => {
module.exports = {
root: true,
plugins: ['markdown', 'node-core'],
parser: 'babel-eslint',
parserOptions: { sourceType: 'script' },
parser: '@babel/eslint-parser',
parserOptions: {
babelOptions: {
plugins: [Module._findPath('@babel/plugin-syntax-class-properties')],
},
requireConfigFile: false,
sourceType: 'script',
},
overrides: [
{
files: [
Expand Down Expand Up @@ -150,6 +157,7 @@ module.exports = {
'no-multiple-empty-lines': ['error', { max: 2, maxEOF: 0, maxBOF: 0 }],
'no-new-require': 'error',
'no-new-symbol': 'error',
'no-nonoctal-decimal-escape': 'error',
'no-obj-calls': 'error',
'no-octal': 'error',
'no-path-concat': 'error',
Expand Down Expand Up @@ -226,6 +234,8 @@ module.exports = {
'no-unreachable': 'error',
'no-unsafe-finally': 'error',
'no-unsafe-negation': 'error',
'no-unsafe-optional-chaining': 'error',
'no-unused-expressions': ['error', { allowShortCircuit: true }],
'no-unused-labels': 'error',
'no-unused-vars': ['error', { args: 'none', caughtErrors: 'all' }],
'no-use-before-define': ['error', {
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/1-bug-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ repo. https://github.com/nodejs/help
Please fill in as much of the template below as you're able.

Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Platform: output of `uname -a` (UNIX), or output of `"$([Environment]::OSVersion | ForEach-Object VersionString) $(if ([Environment]::Is64BitOperatingSystem) { "x64" } else { "x86" })"` in PowerShell console (Windows)
Subsystem: if known, please specify affected core module name
-->

Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/auto-start-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ on:
# ./doc/guides/commit-queue.md
- cron: "*/5 * * * *"

env:
NODE_VERSION: 14.x

jobs:
startCI:
if: github.repository == 'nodejs/node'
Expand All @@ -20,7 +23,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v2-beta
with:
node-version: '12'
node-version: ${{ env.NODE_VERSION }}
- name: Install node-core-utils
run: npm install -g node-core-utils

Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ env:

jobs:
build-tarball:
if: github.event.pull_request.draft == false
env:
PYTHON_VERSION: 3.9
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ env:

jobs:
build-windows-with-quic:
if: github.event.pull_request.draft == false
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/close-stalled.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:

jobs:
stale:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v3
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/comment-stalled.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:

jobs:
staleComment:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- name: Post comment
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/commit-queue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ on:
schedule:
- cron: "*/5 * * * *"

env:
NODE_VERSION: 14.x

jobs:
commitQueue:
if: github.repository == 'nodejs/node'
Expand All @@ -34,7 +37,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v2-beta
with:
node-version: '12'
node-version: ${{ env.NODE_VERSION }}
- name: Install node-core-utils
run: npm install -g node-core-utils@latest

Expand Down
28 changes: 20 additions & 8 deletions .github/workflows/coverage-linux.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,28 @@
# TODO(bcoe): add similar job for Windows coverage.
name: coverage-linux

on:
pull_request:
paths-ignore:
- 'doc/**'
- 'deps/**'
- 'benchmark/**'
- 'tools/**'
push:
branches:
- master
paths-ignore:
- 'doc/**'
- 'deps/**'
- 'benchmark/**'
- 'tools/**'

env:
PYTHON_VERSION: 3.9
FLAKY_TESTS: dontcare

jobs:
# TODO(bcoe): add support for C++ coverage.
coverage-linux:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -23,18 +32,21 @@ jobs:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Install gcovr
run: pip install gcovr==4.2
- name: Build
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn"
run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn --coverage"
# TODO(bcoe): fix the couple tests that fail with the inspector enabled.
# The cause is most likely coverage's use of the inspector.
- name: Test
run: NODE_V8_COVERAGE=coverage/tmp make run-ci -j2 V=1 TEST_CI_ARGS="-p dots" || exit 0
- name: Report
run: NODE_V8_COVERAGE=coverage/tmp make test-cov -j2 V=1 TEST_CI_ARGS="-p dots" || exit 0
- name: Report JS
run: npx c8 report --check-coverage
- name: Output file count
run: ls -l coverage/tmp/ | wc -l
- name: Report C++
run: cd out && gcovr --gcov-exclude='.*\b(deps|usr|out|obj|cctest|embedding)\b' -v -r Release/obj.target --xml -o ../coverage/coverage-cxx.xml --root=$(cd ../ && pwd)
# Clean temporary output from gcov and c8, so that it's not uploaded:
- name: Clean tmp
run: rm -rf coverage/tmp
run: rm -rf coverage/tmp && rm -rf out
- name: Upload
uses: codecov/codecov-action@v1
with:
Expand Down
52 changes: 52 additions & 0 deletions .github/workflows/coverage-windows.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
name: coverage-windows

on:
pull_request:
paths-ignore:
- 'doc/**'
- 'deps/**'
- 'benchmark/**'
- 'tools/**'
push:
branches:
- master
paths-ignore:
- 'doc/**'
- 'deps/**'
- 'benchmark/**'
- 'tools/**'

env:
PYTHON_VERSION: 3.9
FLAKY_TESTS: dontcare

jobs:
coverage-windows:
if: github.event.pull_request.draft == false
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install deps
run: choco install nasm
- name: Environment Information
run: npx envinfo
- name: Build
run: ./vcbuild.bat
# TODO(bcoe): investigate tests that fail with coverage enabled
# on Windows.
- name: Test
run: ./vcbuild.bat test-ci-js; node -e 'process.exit(0)'
env:
NODE_V8_COVERAGE: ./coverage/tmp
- name: Report
run: npx c8 report
- name: Clean tmp
run: npx rimraf ./coverage/tmp
- name: Upload
uses: codecov/codecov-action@v1
with:
directory: ./coverage
23 changes: 23 additions & 0 deletions .github/workflows/license-builder.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: license update
on:
schedule:
# 00:00:00 every Monday
# https://crontab.guru/#0_0_*_*_1
- cron: "0 0 * * 1"
workflow_dispatch:

jobs:
update_license:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- run: "./tools/license-builder.sh" # run the license builder tool
- uses: gr2m/create-or-update-pull-request-action@v1.x # create a PR or update the Action's existing PR
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
title: "doc: run license-builder"
body: "License is likely out of date. This is an automatically generated PR by the `license-builder.yml` GitHub Action, which runs `license-builder.sh` and submits a new PR or updates an existing PR."
commit-message: 'doc: run license-builder'
labels: meta
25 changes: 19 additions & 6 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@ on:

env:
PYTHON_VERSION: 3.9
NODE_VERSION: 10.x
NODE_VERSION: 14.x

jobs:
lint-addon-docs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -24,8 +25,9 @@ jobs:
- name: Environment Information
run: npx envinfo
- name: Lint addon docs
run: NODE=$(which node) make lint-addon-docs
run: NODE=$(command -v node) make lint-addon-docs
lint-cpp:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -38,6 +40,7 @@ jobs:
- name: Lint C/C++ files
run: make lint-cpp
lint-md:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -50,8 +53,9 @@ jobs:
- name: Lint docs
run: |
echo "::add-matcher::.github/workflows/remark-lint-problem-matcher.json"
NODE=$(which node) make lint-md
NODE=$(command -v node) make lint-md
lint-js:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -62,8 +66,9 @@ jobs:
- name: Environment Information
run: npx envinfo
- name: Lint JavaScript files
run: NODE=$(which node) make lint-js
run: NODE=$(command -v node) make lint-js
lint-py:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -76,9 +81,17 @@ jobs:
- name: Lint Python
run: |
make lint-py-build || true
NODE=$(which node) make lint-py

NODE=$(command -v node) make lint-py
lint-sh:
if: github.event.pull_request.draft == false
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- run: shellcheck -V
- name: Lint Shell scripts
run: tools/lint-sh.js .
lint-codeowners:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/misc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@ on:
- v[0-9]+.x

env:
NODE_VERSION: 12.x
NODE_VERSION: 14.x

jobs:
build-docs:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -23,7 +24,7 @@ jobs:
- name: Environment Information
run: npx envinfo
- name: Build
run: NODE=$(which node) make doc-only
run: NODE=$(command -v node) make doc-only
- uses: actions/upload-artifact@v1
with:
name: docs
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-asan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ env:

jobs:
test-asan:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
env:
CC: clang
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ env:

jobs:
test-linux:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -30,6 +31,7 @@ jobs:
run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions"

test-linux-with-quic:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand Down
Loading