fs: validate mode as Int32 in ReadStream/WriteStream constructors#62538
Open
wdskuki wants to merge 1 commit intonodejs:mainfrom
Open
fs: validate mode as Int32 in ReadStream/WriteStream constructors#62538wdskuki wants to merge 1 commit intonodejs:mainfrom
wdskuki wants to merge 1 commit intonodejs:mainfrom
Conversation
Fixes a regression where passing a mode value that exceeds Int32 max (but is within UInt32 range) to createWriteStream or createReadStream would cause an assertion failure crash instead of throwing a catchable RangeError. The issue was introduced when mode validation was moved from JS to C++, but the ReadStream/WriteStream constructors were not updated to validate the mode option before passing it to the C++ layer. Changes: - Import and use parseFileMode in lib/internal/fs/streams.js for both ReadStream and WriteStream constructors - Change parseFileMode in lib/internal/validators.js to use validateInt32 instead of validateUint32 to match C++ expectations - Add regression test for issue nodejs#62516 Fixes: nodejs#62516 PR-URL: TBD Reviewed-By: TBD
nodejs-github-bot
added
fs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression where passing a mode value that exceeds Int32 max (but is within UInt32 range) to createWriteStream or createReadStream would cause an assertion failure crash instead of throwing a catchable RangeError.
The issue was introduced when mode validation was moved from JS to C++, but the ReadStream/WriteStream constructors were not updated to validate the mode option before passing it to the C++ layer.
Changes
parseFileModeinlib/internal/fs/streams.jsfor both ReadStream and WriteStream constructorsparseFileModeinlib/internal/validators.jsto usevalidateInt32instead ofvalidateUint32to match C++ expectationsfs.createWriteStreamresults in crash #62516Testing
Fixes: #62516