stream: refactor duplexify to be less suceptible to prototype pollution#62559
Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
Open
stream: refactor duplexify to be less suceptible to prototype pollution#62559aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95 wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
targos
approved these changes
Apr 2, 2026
Collaborator
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62559 +/- ##
==========================================
- Coverage 89.71% 89.71% -0.01%
==========================================
Files 695 695
Lines 214154 214154
Branches 41009 41006 -3
==========================================
- Hits 192132 192118 -14
- Misses 14075 14083 +8
- Partials 7947 7953 +6
🚀 New features to boost your workflow:
|
ljharb
approved these changes
Apr 2, 2026
Collaborator
marco-ippolito
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the
__proto__: null, the JS engine has to look into e.g.%Object.prototype%.thenwhen trying to resolve the promise