remove de-chartered Intl working group#1513
Merged
fhemberger merged 2 commits intonodejs:masterfrom Dec 12, 2017
Trott:rm-intl
Merged
remove de-chartered Intl working group#1513fhemberger merged 2 commits intonodejs:masterfrom Trott:rm-intl
fhemberger merged 2 commits intonodejs:masterfrom
Trott:rm-intl
Conversation
srl295
approved these changes
Dec 11, 2017
daxlab
approved these changes
Dec 12, 2017
lpinca
approved these changes
Dec 12, 2017
Member
lpinca
left a comment
lpinca
left a comment
There was a problem hiding this comment.
LGTM but it should be removed also for other locales.
Member
Author
Oh, the irony. Removed it from the only two locales that had it. Kept it as a separate commit in case it ought to be moved to a new PR or something. PTAL. |
Member
Author
|
@nodejs/nodejs-ko |
Contributor
|
LGTM for ko locale. |
Contributor
|
Thanks! 👍 |
Member
|
@Trott Internationalization: fresh irony served daily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: nodejs/TSC#353