Drop xmodule mixin support from the xblocks-contrib blocks#38264
Draft
Drop xmodule mixin support from the xblocks-contrib blocks#38264
Conversation
farhan
force-pushed
the
farhan/drop-xmodule-mixin-from-xblocks-contrib
branch
from
a2abe37 to
7d7e607
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop xmodule mixin support from the xblocks-contrib blocks
We can consider it as the common branch for the support of all the xblocks-contrib blocks as most of the fixes will be common.
Relevant xblocks-contrib PR: openedx/xblocks-contrib#225
Relevant xblocks PR: openedx/XBlock#903
Spelunking activity:
PR: #38250
In this PR I tried to avoid the addition of
XModuleMixinto xblocks-contrib blocks but it couldn't happen because of complexity of the code and its dependency on the xblock/runtime.py:Mixologist class