Skip to content

[FC-0118] feat: standardize serializer usage in Enrollment Views#38265

Draft
taimoor-ahmed-1 wants to merge 1 commit intoopenedx:feat/axim-api_improvementsfrom
edly-io:feat/enrollment_allowed_api_serializer_usage
Draft

[FC-0118] feat: standardize serializer usage in Enrollment Views#38265
taimoor-ahmed-1 wants to merge 1 commit intoopenedx:feat/axim-api_improvementsfrom
edly-io:feat/enrollment_allowed_api_serializer_usage

Conversation

@taimoor-ahmed-1
Copy link
Copy Markdown
Contributor

Description

  • Migrates EnrollmentView and EnrollmentAllowedView to explicit DRF
    serializer usage for input validation and output formatting, as required
    by ADR 0025.
  • Removes the check_required_data() helper from EnrollmentAllowedView
    in favour of serializer .is_valid().
  • Adds 20 new response-shape tests that pin the API contract and prevent
    regressions; fixes one pre-existing test whose mock target was made stale
    by the refactor.

…lowedView (ADR 0025)

Migrate EnrollmentView and EnrollmentAllowedView to explicit DRF
serializer usage for both input validation and response formatting,
per the decision recorded in docs/decisions/0025-standardize-serializer-usage.rst.
@taimoor-ahmed-1 taimoor-ahmed-1 requested a review from a team as a code owner April 1, 2026 11:43
@taimoor-ahmed-1 taimoor-ahmed-1 self-assigned this Apr 1, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Apr 1, 2026

Thanks for the pull request, @taimoor-ahmed-1!

This repository is currently maintained by @openedx/wg-maintenance-openedx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 1, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 1, 2026
@taimoor-ahmed-1 taimoor-ahmed-1 marked this pull request as draft April 1, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants