chore(LoginPage): convert examples to TypeScript#7615
Merged
nicolethoen merged 1 commit intopatternfly:mainfrom Jul 8, 2022
Merged
chore(LoginPage): convert examples to TypeScript#7615nicolethoen merged 1 commit intopatternfly:mainfrom
nicolethoen merged 1 commit intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-7615.surge.sh A11y report: https://patternfly-react-pr-7615-a11y.surge.sh |
nicolethoen
requested changes
Jul 5, 2022
Contributor
nicolethoen
left a comment
nicolethoen
left a comment
There was a problem hiding this comment.
Looks pretty good!
one note.
packages/react-core/src/components/LoginPage/examples/LoginPageBasic.tsx
Outdated
Show resolved
Hide resolved
packages/react-core/src/components/LoginPage/examples/LoginPageShowHidePassword.tsx
Outdated
Show resolved
Hide resolved
thatblindgeye
approved these changes
Jul 7, 2022
Signed-off-by: Tomas Psota <tpsota@redhat.com>
tompsota
force-pushed
the
loginpage_to_typescript
branch
from
4586fb8 to
ca23c56
Compare
nicolethoen
approved these changes
Jul 8, 2022
jenny-s51
pushed a commit
to jenny-s51/patternfly-react
that referenced
this pull request
Jul 26, 2022
Signed-off-by: Tomas Psota <tpsota@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also removed duplicated
ExclamationCircleIconfromhelperTextprop in both examples - it is already used ashelperTextIcon.Signed-off-by: Tomas Psota tpsota@redhat.com
What: Closes #7552