Fix #592 - desc index

[predictor2718]

Description

This PR fixes incorrect parsing of DESC inside index definitions in
ALTER TABLE statements.

Example:

ALTER TABLE `t`
  ADD UNIQUE KEY `idx` (`a`, `b` DESC);

This change updates AlterOperation::parse() so that ASC and DESC
are not interpreted as new statements within index definitions.

Fixes #592.

[williamdes]

Thank you for the PR, I am not too sure about using the in array check
Would DeSC still trigger this ?

[predictor2718]

Thank you for the review!

Regarding the question about whether DeSC (or other mixed-case variants) would still trigger the check:

The parser normalizes keywords during lexing.
Lexer::parseKeyword() internally calls Context::isKeyword(), which performs a strtoupper() on the token value.
Because of this, any case variation like DESC, Desc, DeSC, etc. is always mapped to the uppercase keyword DESC.

So the condition is case-insensitive and mixed-case inputs won’t cause issues.

To be safe, I also added additional tests covering:

• ASC
• DESC
• lowercase desc
• two DESC columns

All tests pass with the current implementation.

[williamdes]

Thank you for your reply and Happy New Year!

I have linked the files and added an Asc-Desc and Desc-Asc test.

Best regards

Hi,
Sorry we may be quite slow to merge bug fixes
Even if you closed this request I will merge your work

[predictor2718]

@williamdes
Damn! Sorry, I thought that this had been merged already and I just deleted my fork to create another clean new fork to work at different issues.

[williamdes]

@williamdes Damn! Sorry, I thought that this had been merged already and I just deleted my fork to create another clean new fork to work at different issues.

That's okay, I merged this PR as 5b68e01 into 5.11.x
Be sure to send fixes and small improvements to 5.11.x or similar stable branches