Fix phpstan/phpstan#13380: Promoting protected property to public in subclass generates uninitialized property

[phpstan-bot]

Summary

When a child class redeclares a property from a parent class to change its visibility (e.g. protected to public), and the parent class initializes that property via constructor promotion, PHPStan incorrectly reported the property as uninitialized. This fix recognizes that inherited constructors with promoted properties properly initialize the redeclared property.

Changes

• Modified src/Node/ClassPropertiesNode.php: Added a check in getUninitializedProperties() that detects when a property is promoted in the inherited constructor's declaring class
• Added tests/PHPStan/Rules/Properties/data/bug-13380.php: Regression test data with two scenarios
• Added testBug13380() in tests/PHPStan/Rules/Properties/UninitializedPropertyRuleTest.php

Root cause

In ClassPropertiesNode::getUninitializedProperties(), the initialization check only looked at whether the property was promoted in the current class ($property->isPromoted()). When a child class redeclares the property (to widen visibility), the property node in the child class is not promoted — it's a plain property declaration. The parent's constructor body isn't in the child's returnStatementNodes, so collectUninitializedProperties() also couldn't detect the initialization.

The fix adds a check: if the class has a constructor inherited from a parent class, and that parent class promotes the property, then the property is considered initialized.

Test

The regression test covers:

• Bar extends Foo — redeclares $prop as public (no own constructor) → should have no error
• Baz extends Foo — redeclares $prop as public with own empty constructor → should report uninitialized

Fixes phpstan/phpstan#13380

[VincentLanglet]

A case like

class Foo
{
	public function __construct(
		protected string $prop,
	){
	}
}

class Bar extends Foo
{
	public function __construct(
		string $prop,
	){
		parent::__construct($prop);
	}
}

class Baz extends Bar {
	public string $prop;
}

should be supported too.

[phpstan-bot]

Background test suite also completed successfully. All changes have been committed and pushed.

[VincentLanglet]

I think

class Foo3
{
	public function __construct(
		protected string $prop,
	){
	}
}

class Bar3 extends Foo3
{
	public function __construct(
	){
	}
}

class Baz3 extends Bar3 {
	public string $prop;
}

should still be reported then

[phpstan-bot]

The background test suite also completed successfully (all 11708 tests passed). The fix has been committed and pushed.

[VincentLanglet]

class Foo
{
	public function __construct(
		private string $prop,
	){
	}
}

class Bar extends Foo {
	public string $prop;
}

should still report an error

[phpstan-bot]

make tests also completed successfully. All done — both background tasks confirmed passing, and the fix has already been pushed.