Fix Inf coordinate values causing shapes not to render#2478
Fix Inf coordinate values causing shapes not to render#2478Chr96er wants to merge 1 commit intoplotly:masterfrom
Conversation
JSON doesn't support Inf values - they become null, causing geoms like geom_rect, geom_polygon, geom_line, geom_ribbon, and geom_segment to not render when users specify Inf/-Inf coordinates (a common pattern for "extend to edge" annotations). This fix adds centralized Inf replacement in the ggplot2-to-plotly conversion pipeline, replacing Inf values with the corresponding panel limits after to_basic() returns. This handles all geoms generically without requiring individual fixes. Includes tests for geom_line, geom_rect, geom_polygon, and faceted plots to verify both that Inf values are replaced and that the replacement values match the expected panel limits.
|
Thanks for this contribution, @Chr96er! This is a really nice approach — handling Inf replacement centrally after NEWS.md entryPlease add a bullet under the Comment accuracy in
|
Summary
Fixes #2364 - JSON doesn't support Inf values, causing geoms to not render when users specify Inf/-Inf coordinates (a common pattern for "extend to edge" annotations).
Changes
replace_inf_in_data()function inR/utils.Rthat replaces Inf values with panel limitsto_basic()returns inR/layers2traces.R, handling all geoms generically (geom_line, geom_rect, geom_polygon, geom_ribbon, geom_segment, etc.)Test plan