Skip to content

Fix formatting a log message #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ccordoba12 merged 3 commits into from
Nov 25, 2021
+2 −4
Merged

Fix formatting a log message #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e814b7d
Fix formatting a log message
ccordoba12 Nov 25, 2021
61aa69d
Use f-string to please Pylint
ccordoba12 Nov 25, 2021
019c61d
Fix wrong copy/paste
ccordoba12 Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ disable =
too-many-instance-attributes,
import-error,
consider-using-f-string,
logging-fstring-interpolation

[REPORTS]

Expand Down
5 changes: 1 addition & 4 deletions pylsp/plugins/_resolvers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,7 @@ def resolve(self, completion):
sig = completion.get_signatures()
return self.callback(completion, sig)
except Exception as e: # pylint: disable=broad-except
log.warning(
'Something went wrong when resolving label for {completion}: {e}',
completion=completion, e=e
)
log.warning(f'Something went wrong when resolving label for {completion}: {e}')
return self.resolve_on_error


Expand Down