setup isort & black, introduce pre-commit#331
setup isort & black, introduce pre-commit#331syphar wants to merge 2 commits intopython-lsp:developfrom
Conversation
|
btw, if feels like the readabilty could benefit from a smaller maximum line length (100?), but that's up to you |
|
If the majority of the code uses single quotes already then don't you think that the configuration should be aligned with that to introduce least amount of noise to the PR and follow the preference of the main contributors? |
|
that's a design question, and totally up to the contributors. Its configurable (via IMO the main advantage of black is the opinionated style, but that's just me. |
|
Another argument for single quotes could be that it's just easier to type on most popular keyboard layouts (US, EN) since it's just one key instead of two. That said, if the quotes will be auto-fixed then maybe it doesn't matter. As you said, up to main contributors and I'm not one of them. |
|
Closing as superseded by #419. Precommit can be added in another PR. |
As discussed.
I kept the configuration & the actual reformat separate.
E203,W503) are due to https://black.readthedocs.io/en/stable/faq.html#why-are-flake8-s-e203-and-w503-violated.git-blame-ignore-revsto remove it from eventualgit blameresults.Of course we can discuss settings, or discard this completely if you don't like the format :)