Skip to content

Black format Repo#407

Closed
tkrabel-db wants to merge 25 commits intopython-lsp:developfrom
tkrabel-db:black-format
Closed

Black format Repo#407
tkrabel-db wants to merge 25 commits intopython-lsp:developfrom
tkrabel-db:black-format

Conversation

@tkrabel-db
Copy link
Copy Markdown
Contributor

@tkrabel-db tkrabel-db commented Jul 27, 2023

What is changed in that PR?

Addresses #392, i.e. this PR auto formats the whole repo using black to see the diff.

black is arguably the most popular formatter out there.

What needs to be changed further?

Some black re-formattings violate pylint and pycodestyle, e.g.

pycodestyle

test/test_text_edit.py:27:9: W503 line break before binary operator
test/test_text_edit.py:42:9: W503 line break before binary operator
test/test_text_edit.py:64:9: W503 line break before binary operator
test/test_text_edit.py:107:9: W503 line break before binary operator
test/test_text_edit.py:128:9: W503 line break before binary operator
test/test_text_edit.py:150:9: W503 line break before binary operator
test/test_text_edit.py:172:9: W503 line break before binary operator
test/test_text_edit.py:194:9: W503 line break before binary operator
test/test_text_edit.py:216:9: W503 line break before binary operator
test/test_text_edit.py:302:9: W503 line break before binary operator
test/test_workspace.py:320:13: W503 line break before binary operator
test/test_workspace.py:322:9: W503 line break before binary operator
test/test_workspace.py:371:13: W503 line break before binary operator
test/test_workspace.py:373:9: W503 line break before binary operator
test/test_workspace.py:416:13: W503 line break before binary operator
test/test_workspace.py:418:9: W503 line break before binary operator
test/plugins/test_autopep8_format.py:85:9: W503 line break before binary operator
test/plugins/test_yapf_format.py:67:9: W503 line break before binary operator
test/plugins/test_yapf_format.py:78:9: W503 line break before binary operator

pylint pylsp

************* Module test.test_workspace
test/test_workspace.py:240:0: W1404: Implicit string concatenation found in call (implicit-str-concat)
test/test_workspace.py:259:0: W1404: Implicit string concatenation found in call (implicit-str-concat)
************* Module pylsp.plugins.pylint_lint
pylsp/plugins/pylint_lint.py:292:12: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
pylsp/plugins/pylint_lint.py:294:0: I0021: Useless suppression of 'consider-using-with' (useless-suppression)
************* Module pylsp.plugins.rope_autoimport
pylsp/plugins/rope_autoimport.py:33:0: R0911: Too many return statements (7/6) (too-many-return-statements)
pylsp/plugins/rope_autoimport.py:35:0: I0021: Useless suppression of 'too-many-return-statements' (useless-suppression)

tkrabel-db added 25 commits June 5, 2023 12:21
Support notebookDocument/didOpen and textDocument/publishDiagnostics on a notebook document
too-many-public-methods, dangerous-default-value, unused-import, too-many-locals, redefined-outer-name
…iagnostics notification since the first call is a n empty diagnostics for the closed cell
@ccordoba12
Copy link
Copy Markdown
Member

Thanks a lot for your help with this @tkrabel-db! Could you resume your work after PR #389 is merged? Thanks!

@tkrabel-db
Copy link
Copy Markdown
Contributor Author

I close this an open a new PR, since solving the merge conflicts is messy and I don't want to cause a regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants