Skip to content

gh-71784: [doc] add usage examples for traceback.TracebackException#125189

Merged
AlexWaygood merged 18 commits intopython:mainfrom
iritkatriel:gh-71784
Oct 10, 2024
Merged

gh-71784: [doc] add usage examples for traceback.TracebackException#125189
AlexWaygood merged 18 commits intopython:mainfrom
iritkatriel:gh-71784

Conversation

@iritkatriel
Copy link
Copy Markdown
Member

@iritkatriel iritkatriel commented Oct 9, 2024 •
edited by github-actions bot
Loading

@iritkatriel iritkatriel added docs Documentation in the Doc dir needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 9, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 9, 2024
Closed
@iritkatriel iritkatriel mentioned this pull request Oct 9, 2024
Closed
iritkatriel
iritkatriel commented Oct 9, 2024
View reviewed changes
iritkatriel
iritkatriel commented Oct 9, 2024
View reviewed changes
AlexWaygood
AlexWaygood reviewed Oct 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

AlexWaygood
AlexWaygood reviewed Oct 9, 2024
View reviewed changes
AlexWaygood
AlexWaygood reviewed Oct 9, 2024
View reviewed changes
iritkatriel and others added 2 commits October 9, 2024 20:06
@iritkatriel @AlexWaygood
Apply suggestions from code review
edda8e4 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@iritkatriel @AlexWaygood
Apply suggestions from code review
ee9674e 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Oct 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@iritkatriel
Copy link
Copy Markdown
Member Author

iritkatriel commented Oct 9, 2024

Thank you @AlexWaygood !

@iritkatriel iritkatriel enabled auto-merge (squash) October 9, 2024 19:22
@iritkatriel
Copy link
Copy Markdown
Member Author

iritkatriel commented Oct 9, 2024

The docktest is failing. How do I run it on a Mac?

@AlexWaygood
Copy link
Copy Markdown
Member

AlexWaygood commented Oct 9, 2024

make doctest from the Doc/ directory should do it. I'd also be okay with removing the .. doctest directive if it's too tricky; I now remember that it can be annoying getting doctests involving traceback output to work properly

@iritkatriel
Copy link
Copy Markdown
Member Author

iritkatriel commented Oct 9, 2024

make doctest from the Doc/ directory should do it. I'd also be okay with removing the .. doctest directive if it's too tricky; I now remember that it can be annoying getting doctests involving traceback output to work properly

Yes, and also they changed over the last few releases with locations/hilighting so it won't backport. I'll remove it.

@iritkatriel iritkatriel disabled auto-merge October 10, 2024 08:29
@AlexWaygood AlexWaygood merged commit f9ae5d1 into python:main Oct 10, 2024
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app bot commented Oct 10, 2024

Thanks @iritkatriel for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2024
@iritkatriel @AlexWaygood @miss-islington
pythongh-71784: [doc] add usage examples for traceback.TracebackExcep…
291777f 
…tion (pythonGH-125189)

(cherry picked from commit f9ae5d1)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2024
@iritkatriel @AlexWaygood @miss-islington
pythongh-71784: [doc] add usage examples for traceback.TracebackExcep…
7bfe482 
…tion (pythonGH-125189)

(cherry picked from commit f9ae5d1)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Oct 10, 2024

GH-125247 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 10, 2024
@bedevere-app
Copy link
Copy Markdown

bedevere-app bot commented Oct 10, 2024

GH-125248 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 10, 2024
AlexWaygood added a commit that referenced this pull request Oct 10, 2024
@miss-islington @iritkatriel @AlexWaygood
[3.12] gh-71784: [doc] add usage examples for traceback.TracebackExce…
01daccf 
…ption (GH-125189) (#125248)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Oct 10, 2024
@miss-islington @iritkatriel @AlexWaygood
[3.13] gh-71784: [doc] add usage examples for traceback.TracebackExce…
47ad32d 
…ption (GH-125189) (#125247)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iritkatriel @AlexWaygood