gh-125895: Docs: fix 404 page prefix configuration#139386
Closed
m-aciek wants to merge 1 commit intopython:mainfrom
Closed
gh-125895: Docs: fix 404 page prefix configuration#139386m-aciek wants to merge 1 commit intopython:mainfrom
m-aciek wants to merge 1 commit intopython:mainfrom
Conversation
The default is /en/latest/, but current docs hosting doesn't use this pattern. There's one 404 page for whole docs subdomain, so there's no need to provide a prefix per-version and/or per-language.
Contributor
Author
|
Doesn't break the RTD configuration: 404 in preview is still rendered correctly. |
Member
|
Will this work for other version builds such as https://docs.python.org/3.15/ and https://docs.python.org/dev/ ? And for translations such as https://docs.python.org/pl/3/ and https://docs.python.org/pl/3.15/ ? |
Member
|
Indeed, this won't work properly. We would need to do this dynamically in docsbuild-scripts. As such, I'll close. A |
Contributor
Author
|
We should set https://docs.python.org/3/404.html as a global 404 page (for whole subdomain). That way it will work for all versions. Nice to have would be to set a 404 page per build, but:
<li id="cpython-language-and-version">
<a href="/3/index.html">3.15.0a0 Documentation</a> »
</li>
<script src="/3/_static/documentation_options.js?v=048d8b21"></script>
<script src="/3/_static/doctools.js?v=9bcbadda"></script>
<script src="/3/_static/sphinx_highlight.js?v=dc90522c"></script>
<script src="/3/_static/sidebar.js"></script>I think having a global 404 with English latest stable link (without the nice to have) is just fine, or at least fine until we figure out how to improve it. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The default is
/en/latest/. Our docs use/3/for latest stable version documentation build. That way links and resources URLs will be correct in the generated 404 page, in the docs.python.org subdomain.Closes #125895 if followed-up by nginx's (https://nginx.org/en/docs/http/ngx_http_core_module.html#error_page) directive config.
(This change doesn't require a news entry.)
📚 Documentation preview 📚: https://cpython-previews--139386.org.readthedocs.build/