Skip to content

bpo-37335: Remove unnecessary code from c locale coercion tests#14447

Merged
vstinner merged 2 commits intopython:masterfrom
kulikjak:remove-unnecessary-test-locale-coercion-code
Jul 2, 2019
Merged

bpo-37335: Remove unnecessary code from c locale coercion tests#14447
vstinner merged 2 commits intopython:masterfrom
kulikjak:remove-unnecessary-test-locale-coercion-code

Conversation

@kulikjak
Copy link
Copy Markdown
Contributor

@kulikjak kulikjak commented Jun 28, 2019

Python 3.8+ encodings are always normalized and thus no output variations handling is necessary (the code is no longer necessary).

https://bugs.python.org/issue37335

@vstinner vstinner merged commit 61bf97e into python:master Jul 2, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @kulikjak for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

GH-14552 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 2, 2019
…14447)

Python initialization now ensures that sys stream encoding
names are always normalized by codecs.lookup(encoding).name.
Simplify test_c_locale_coercion: it doesn't have to normalize
encoding names anymore.
(cherry picked from commit 61bf97e)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
@vstinner
Copy link
Copy Markdown
Member

vstinner commented Jul 2, 2019

Thanks, I merged your PR. I enhanced the commit message to better elaborate the change.

miss-islington added a commit that referenced this pull request Jul 2, 2019
Python initialization now ensures that sys stream encoding
names are always normalized by codecs.lookup(encoding).name.
Simplify test_c_locale_coercion: it doesn't have to normalize
encoding names anymore.
(cherry picked from commit 61bf97e)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
…14447)

Python initialization now ensures that sys stream encoding
names are always normalized by codecs.lookup(encoding).name.
Simplify test_c_locale_coercion: it doesn't have to normalize
encoding names anymore.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
…14447)

Python initialization now ensures that sys stream encoding
names are always normalized by codecs.lookup(encoding).name.
Simplify test_c_locale_coercion: it doesn't have to normalize
encoding names anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants