Skip to content

bpo-37441: Fix a param error in exceptions.rst#14453

Merged
zhangyangyu merged 1 commit intopython:masterfrom
shihai1991:bpo_37441
Jul 3, 2019
Merged

bpo-37441: Fix a param error in exceptions.rst#14453
zhangyangyu merged 1 commit intopython:masterfrom
shihai1991:bpo_37441

Conversation

@shihai1991
Copy link
Copy Markdown
Member

@shihai1991 shihai1991 commented Jun 28, 2019

@tirkarthi
Copy link
Copy Markdown
Member

I think the PR is linked to wrong issue. I guess you have to change the issue number to 37441. Thanks.

@shihai1991 shihai1991 changed the title bpo-37411: Fix a param error in exceptions.rst bpo-37441: Fix a param error in exceptions.rst Jun 28, 2019
@shihai1991
Copy link
Copy Markdown
Member Author

I think the PR is linked to wrong issue. I guess you have to change the issue number to 37441. Thanks.

ops, thank you.

Copy link
Copy Markdown
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems to have been added as part of 46f97b8. Thanks.

@tirkarthi
Copy link
Copy Markdown
Member

cc: @ericsnowcurrently

@zhangyangyu zhangyangyu merged commit aeecf38 into python:master Jul 3, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @shihai1991 for the PR, and @zhangyangyu for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link
Copy Markdown

GH-14565 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2019
…ythonGH-14453)

(cherry picked from commit aeecf38)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

GH-14566 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2019
…ythonGH-14453)

(cherry picked from commit aeecf38)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
miss-islington added a commit that referenced this pull request Jul 3, 2019
…H-14453)

(cherry picked from commit aeecf38)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
miss-islington added a commit that referenced this pull request Jul 3, 2019
…H-14453)

(cherry picked from commit aeecf38)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants