Use reusable-docs.yml in documentation-links#145346
Use reusable-docs.yml in documentation-links#145346KowalskiThomas wants to merge 4 commits intopython:mainfrom
reusable-docs.yml in documentation-links#145346Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
This reminds me, https://github.com/readthedocs/actions is deprecated and we're planning to switch to using the Read the Docs app, see python/core-workflow#587. |
|
@hugovk thanks for your comment, based on what I see on the PR you linked the work is still a few repos away from being usable in CPython, right? Happy to take a stab at it if that's what you were suggesting, but my understanding is that it's not time yet. |
|
Yeah, initially the idea was to wait a bit, but I now think we should do CPython first: python/core-workflow#587 (comment). So instead we'll need to do some config via the RTD web UI and then remove this file. |
Do you expect this to be happening soon? Just to know if I close this PR or if I leave it open! |
|
Yeah hopefully, when @JacobCoffee has time for it, although he's the only one in the infra team right now. Relatedly, if you know someone in the US who's looking for a job, the PSF is recruiting! Spread the word! https://jobs.pyfound.org/apply/DNzZlBUqFn/Infrastructure-Engineer |
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
What is this?
Currently, the
documentation-linksrefers todoc.ymlwhich doesn't exist.I suspect the correct file to reference isAfter some Git archeology, this turned out to be incorrect.reusable-docs.yml, based on just looking at commit history fordoc.ymland seeing 88d14da.Seems like
documentation-links.ymlwas added in #103843 (back then,doc.ymldid exist). My bet would be thatdoc.ymlwas copy-pasted todocumentation_links.ymland this bit was not updated. In the meantime,doc.ymlwas renamed toreusable-docs.yml, which is what made me think that was the right new thing to run when changed.Note I didn't add neither a GitHub Issue number nor a News entry as I don't think this warrants either, but feel free to tell me if I should.