Skip to content

Use reusable-docs.yml in documentation-links#145346

Open
KowalskiThomas wants to merge 4 commits intopython:mainfrom
KowalskiThomas:kowalski/use-reusable-docs-yml-in-documentation-links
Open

Use reusable-docs.yml in documentation-links#145346
KowalskiThomas wants to merge 4 commits intopython:mainfrom
KowalskiThomas:kowalski/use-reusable-docs-yml-in-documentation-links

Conversation

@KowalskiThomas
Copy link
Copy Markdown
Contributor

@KowalskiThomas KowalskiThomas commented Feb 28, 2026

What is this?

Currently, the documentation-links refers to doc.yml which doesn't exist.

I suspect the correct file to reference is reusable-docs.yml, based on just looking at commit history for doc.yml and seeing 88d14da. After some Git archeology, this turned out to be incorrect.

Seems like documentation-links.yml was added in #103843 (back then, doc.yml did exist). My bet would be that doc.yml was copy-pasted to documentation_links.yml and this bit was not updated. In the meantime, doc.yml was renamed to reusable-docs.yml, which is what made me think that was the right new thing to run when changed.

Note I didn't add neither a GitHub Issue number nor a News entry as I don't think this warrants either, but feel free to tell me if I should.

@bedevere-app

This comment was marked as resolved.

@hugovk
Copy link
Copy Markdown
Member

hugovk commented Mar 1, 2026

This reminds me, https://github.com/readthedocs/actions is deprecated and we're planning to switch to using the Read the Docs app, see python/core-workflow#587.

@KowalskiThomas KowalskiThomas marked this pull request as ready for review March 3, 2026 08:32
@KowalskiThomas KowalskiThomas requested a review from webknjaz March 3, 2026 08:32
@KowalskiThomas
Copy link
Copy Markdown
Contributor Author

@hugovk thanks for your comment, based on what I see on the PR you linked the work is still a few repos away from being usable in CPython, right? Happy to take a stab at it if that's what you were suggesting, but my understanding is that it's not time yet.

@hugovk
Copy link
Copy Markdown
Member

hugovk commented Mar 3, 2026

Yeah, initially the idea was to wait a bit, but I now think we should do CPython first: python/core-workflow#587 (comment).

So instead we'll need to do some config via the RTD web UI and then remove this file.

@KowalskiThomas
Copy link
Copy Markdown
Contributor Author

So instead we'll need to do some config via the RTD web UI and then remove this file.

Do you expect this to be happening soon? Just to know if I close this PR or if I leave it open!

@hugovk
Copy link
Copy Markdown
Member

hugovk commented Mar 9, 2026

Yeah hopefully, when @JacobCoffee has time for it, although he's the only one in the infra team right now.

Relatedly, if you know someone in the US who's looking for a job, the PSF is recruiting! Spread the word!

https://jobs.pyfound.org/apply/DNzZlBUqFn/Infrastructure-Engineer

Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@KowalskiThomas KowalskiThomas requested a review from webknjaz April 3, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants