Skip to content

gh-142927: Show self time in flamegraph tooltip #147706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivonastojanovic wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −2
Open

gh-142927: Show self time in flamegraph tooltip #147706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Lib/profiling/sampling/_flamegraph_assets/flamegraph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,8 @@ function createPythonTooltip(data) {
}

const timeMs = (d.data.value / 1000).toFixed(2);
const selfSamples = d.data.self || 0;
const selfMs = (selfSamples / 1000).toFixed(2);
const percentage = ((d.data.value / data.value) * 100).toFixed(2);
const calls = d.data.calls || 0;
const childCount = d.children ? d.children.length : 0;
Expand Down Expand Up @@ -403,9 +405,14 @@ function createPythonTooltip(data) {
${fileLocationHTML}
</div>
<div class="tooltip-stats">
<span class="tooltip-stat-label">Execution Time:</span>
<span class="tooltip-stat-label">Total Time:</span>
<span class="tooltip-stat-value">${timeMs} ms</span>

${selfSamples > 0 ? `
<span class="tooltip-stat-label">Self Time:</span>
<span class="tooltip-stat-value">${selfMs} ms</span>
` : ''}

<span class="tooltip-stat-label">Percentage:</span>
<span class="tooltip-stat-value accent">${percentage}%</span>

Expand Down Expand Up @@ -1271,6 +1278,7 @@ function accumulateInvertedNode(parent, stackFrame, leaf, isDifferential) {
const newNode = {
name: stackFrame.name,
value: 0,
self: 0,
children: {},
filename: stackFrame.filename,
lineno: stackFrame.lineno,
Expand All @@ -1293,6 +1301,7 @@ function accumulateInvertedNode(parent, stackFrame, leaf, isDifferential) {

const node = parent.children[key];
node.value += leaf.value;
node.self += stackFrame.self || 0;
if (leaf.threads) {
leaf.threads.forEach(t => node.threads.add(t));
}
Expand Down
1 change: 1 addition & 0 deletions Lib/profiling/sampling/stack_collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ def convert_children(children, min_samples):
child_entry = {
"name": name_idx,
"value": samples,
"self": node.get("self", 0),
"children": [],
"filename": filename_idx,
"lineno": func[1],
Expand Down
4 changes: 3 additions & 1 deletion Lib/test/test_profiling/test_sampling_profiler/test_collectors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,12 +435,14 @@ def test_flamegraph_collector_basic(self):
strings = data.get("strings", [])
name = resolve_name(data, strings)
self.assertTrue(name.startswith("Program Root: "))
self.assertIn("func2 (file.py:20)", name) # formatted name
self.assertIn("func2 (file.py:20)", name)
self.assertEqual(data["self"], 0) # non-leaf: no self time
children = data.get("children", [])
self.assertEqual(len(children), 1)
child = children[0]
self.assertIn("func1 (file.py:10)", resolve_name(child, strings))
self.assertEqual(child["value"], 1)
self.assertEqual(child["self"], 1) # leaf: all time is self

def test_flamegraph_collector_export(self):
"""Test flamegraph HTML export functionality."""
Expand Down
Loading