gh-147957: pop items from UserDict in LIFO order#147958
Open
Andrew5057 wants to merge 6 commits intopython:mainfrom
Open
gh-147957: pop items from UserDict in LIFO order#147958Andrew5057 wants to merge 6 commits intopython:mainfrom
Andrew5057 wants to merge 6 commits intopython:mainfrom
Conversation
`UserDict.popitem` used to pop first-in, first-out since that's the `MutableMapping` implementation. It now pops first-in, last-out since that's the behavior guaranteed for `dict` starting in Python 3.7.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
The last commit used the wrong verbiage in a comment. This fixes it and clarifies that MutableMapping uses FIFO.
Switch from single to double backticks for inline code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UserDict.popitemused to pop last-in, first-out since that's theMutableMappingimplementation. This PR makes it pop last-in, first-out since that's the behavior guaranteed fordictstarting in Python 3.7. Given that the purpose ofUserDictis to make pseudo-subclassingdicteasier, this method should align with its behavior indictto avoid unexpected behavior.