gh-73613: Support Base32 and Base64 without padding#147974
Open
serhiy-storchaka wants to merge 5 commits intopython:mainfrom
Open
gh-73613: Support Base32 and Base64 without padding#147974serhiy-storchaka wants to merge 5 commits intopython:mainfrom
serhiy-storchaka wants to merge 5 commits intopython:mainfrom
Conversation
Add the padded parameter in functions related to Base32 and Base64 codecs in the binascii and base64 modules. In the encoding functions it controls whether the pad character can be added in the output, in the decoding functions it controls whether padding is required in input. Padding of input no longer required in base64.urlsafe_b64decode() by default.
Member
|
I noticed the https://github.com/python/cpython/actions/runs/23856718203/job/69552191340?pr=147974 failure, looking into it. |
gpshead
reviewed
Apr 2, 2026
Member
There was a problem hiding this comment.
_B32_ENCODE_DOCSTRING and _B32_DECODE_DOCSTRING templates need updating.
Member
Author
There was a problem hiding this comment.
Oh, I forgot to update docstrings!
I think it is better to get rid of _B32_ENCODE_DOCSTRING and _B32_DECODE_DOCSTRING templates and use normal docstrings. We already have a lot of near duplicates. But this is for a different issue.
Co-authored-by: Gregory P. Smith <68491+gpshead@users.noreply.github.com>
Member
Author
|
Thank you @StanFromIreland. I thought it was a temporary issue which has already been fixed, because tests were passed after synchronizing with main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the padded parameter in functions related to Base32 and Base64 codecs in the binascii and base64 modules. In the encoding functions it controls whether the pad character can be added in the output, in the decoding functions it controls whether padding is required in input.
Padding of input no longer required in base64.urlsafe_b64decode() by default.
📚 Documentation preview 📚: https://cpython-previews--147974.org.readthedocs.build/