[3.14] gh-146488: hash-pin all action references (gh-146489)#147983
[3.14] gh-146488: hash-pin all action references (gh-146489)#147983woodruffw wants to merge 3 commits intopython:3.14from
Conversation
This is like python#146489, but recreated for 3.13 because of CI drift. Important: unlike the others, this leaves some unpinned `@master` references because pinact won't pin those by default. I can also pin them (they're pinned on the living head), but haven't done so yet. Please let me know what you'd prefer! Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
requested review from
1st1,
AA-Turner,
brandtbucher,
ezio-melotti,
hugovk,
pfmoore,
pradyunsg,
savannahostrowski and
webknjaz
as code owners
|
If we decided to pin |
|
Agreed with @hugovk, whatever we have in |
Signed-off-by: William Woodruff <william@yossarian.net>
|
Done! Unfortunately I think Dependabot and other tools don't do a good job of auto-bumping those kind of |
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Let's also remove unpinned-uses from .github/zizmor.yml in all of these backports.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Oops, thanks. It wasn't present in some of the older version branches so I didn't think to remove it elsewhere... |
Signed-off-by: William Woodruff <william@yossarian.net>
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @hugovk: please review the changes made to this pull request. |
4 participants
This is like #146489, but recreated for 3.14 because of CI drift.
Important: unlike the others, this leaves some unpinned
@masterreferences because pinact won't pin those by default. I can also pin them (they're pinned on the living head), but haven't done so yet. Please let me know what you'd prefer!