gh-147998: Fix possible memory leak in _pop_preserved (crossinterp.c)#147999
Open
maurycy wants to merge 2 commits intopython:mainfrom
Open
gh-147998: Fix possible memory leak in _pop_preserved (crossinterp.c)#147999maurycy wants to merge 2 commits intopython:mainfrom
maurycy wants to merge 2 commits intopython:mainfrom
Conversation
_pop_preserved
Member
|
Could you please add a NEWS entry?
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cpython/Python/crossinterp.c
Line 2968 in 7817651
cpython/Python/crossinterp.c
Line 2991 in 7817651
The
xidataseems to be shadowed inside theelse, and theerror:path does not see it, resulting in a (small) memory leak.It's no longer reproducible:
_pop_preserved()#147998