Skip to content

GH-148047: Check early whether tail-calling is possible for MSVC builds on Windows #148036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chris-eibl wants to merge 4 commits into
base: main
Choose a base branch
from
+11 −0
Open

GH-148047: Check early whether tail-calling is possible for MSVC builds on Windows #148036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15b0bf1
check tail-calling support in pythoncore.vcxproj
chris-eibl Mar 27, 2026
92a236d
Merge branch 'main' into CheckTailCalling
chris-eibl Apr 3, 2026
3a28aeb
Merge remote-tracking branch 'upstream/main' into CheckTailCalling
chris-eibl Apr 3, 2026
8768351
blurb it
chris-eibl Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Build/2026-04-03-20-09-46.gh-issue-148047.HE6iGK.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Check early whether tail-calling is possible for MSVC builds on Windows.
Patch by Chris Eibl.
9 changes: 9 additions & 0 deletions PCbuild/pythoncore.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,4 +749,13 @@
<Target Name="_DeletePyBuildDirTxt" BeforeTargets="PrepareForBuild">
<Delete Files="$(OutDir)pybuilddir.txt" />
</Target>

<Target Name="_CheckTailCalling" BeforeTargets="PrepareForBuild" Condition="'$(UseTailCallInterp)' == 'true' and $(PlatformToolset) != 'ClangCL'">
<Error Text="MSVC supports tail-calling only for x64."
Condition="$(Platform) != 'x64'" />
<Error Text="Platform toolset >= v145 is required for tail-calling."
Condition="$(PlatformToolset.Replace('v', '0')) &lt; '145'" />
<Error Text="MSVC requires optimization to be enabled for tail-calling."
Condition="$(Configuration) == 'Debug'" />
</Target>
</Project>
Loading