Skip to content

[3.8] Update interpreter.rst (GH-17059)#17060

Merged
vstinner merged 2 commits intopython:3.8from
Seluj78:backport-5e01a65-3.8
Nov 5, 2019
Merged

[3.8] Update interpreter.rst (GH-17059)#17060
vstinner merged 2 commits intopython:3.8from
Seluj78:backport-5e01a65-3.8

Conversation

@Seluj78
Copy link
Copy Markdown
Contributor

@Seluj78 Seluj78 commented Nov 5, 2019

Fixed what seemed to be a weird phrasing..
(cherry picked from commit 5e01a65)

Co-authored-by: Jules Lasne (jlasne) jules.lasne@gmail.com

@Seluj78
[3.8] Update interpreter.rst (pythonGH-17059)
fc88007 
Fixed what seemed to be a weird phrasing..
(cherry picked from commit 5e01a65)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Nov 5, 2019
Merged
@Seluj78
Copy link
Copy Markdown
Contributor Author

Seluj78 commented Nov 5, 2019

This is a backport of #17059 for 3.8. I had to move around the lines to respect the 80 chars per line but I am unsure if that was necessary

vstinner
vstinner approved these changes Nov 5, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner merged commit 1eac437 into python:3.8 Nov 5, 2019
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Nov 5, 2019

Thanks @Seluj78 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Nov 5, 2019

Sorry, @Seluj78 and @vstinner, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1eac437e8da106a626efffe9fce1cb47dbf5be35 3.7

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Nov 5, 2019

@Seluj78 sadly the backport to 3.7 failed again :-(

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 5, 2019

GH-17061 is a backport of this pull request to the 3.7 branch.

Seluj78 added a commit to Seluj78/cpython that referenced this pull request Nov 5, 2019
@Seluj78
[3.7] [3.8] Update interpreter.rst (pythonGH-17059) (pythonGH-17060)
2110aea 
Fixed what seemed to be a weird phrasing.

(cherry picked from commit 5e01a65)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>.
(cherry picked from commit 1eac437)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
@Seluj78
Copy link
Copy Markdown
Contributor Author

Seluj78 commented Nov 5, 2019

Done for the 3.7 backport

vstinner pushed a commit that referenced this pull request Nov 5, 2019
@Seluj78 @vstinner
[3.7] [3.8] Update interpreter.rst (GH-17059) (GH-17060) (GH-17061)
1bfc567 
Fixed what seemed to be a weird phrasing.

(cherry picked from commit 5e01a65)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>.
(cherry picked from commit 1eac437)

Co-authored-by: Jules Lasne (jlasne) <jules.lasne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

@vstinner vstinner

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Seluj78 @miss-islington @vstinner @bedevere-bot @the-knights-who-say-ni