Skip to content

Clarify amount of dots between package and subpackage#17092

Merged
willingc merged 1 commit intopython:masterfrom
susan-shu-c:patch-2
Nov 8, 2019
Merged

Clarify amount of dots between package and subpackage#17092
willingc merged 1 commit intopython:masterfrom
susan-shu-c:patch-2

Conversation

@susan-shu-c
Copy link
Copy Markdown
Contributor

@susan-shu-c susan-shu-c commented Nov 8, 2019

No description provided.

@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Nov 8, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@susan-shu-c

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 8, 2019
brandtbucher
brandtbucher approved these changes Nov 8, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @susan-shu-c!

@brandtbucher
Copy link
Copy Markdown
Member

brandtbucher commented Nov 8, 2019

CC @willingc

willingc
willingc approved these changes Nov 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction.

@willingc willingc merged commit fc6b1bf into python:master Nov 8, 2019
@brandtbucher
Copy link
Copy Markdown
Member

brandtbucher commented Nov 8, 2019

Congrats on your first CPython contribution @susan-shu-c! 🍾

Looking forward to seeing more from you in the future.

@susan-shu-c
Copy link
Copy Markdown
Contributor Author

susan-shu-c commented Nov 8, 2019

Thanks for the fast response brandtbucher and willingc! Super excited and thanks for the welcome! 🐍

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@susan-shu-c
Clarify amount of dots between package and subpackage (pythonGH-17092)
fba950e
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@susan-shu-c @shihai1991
Clarify amount of dots between package and subpackage (pythonGH-17092)
6cec06b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@susan-shu-c @the-knights-who-say-ni @brandtbucher @willingc @bedevere-bot